andrew/akbasic
1
0
Fork 0
Code Issues 31 Pull Requests 1 Actions 3 Packages Projects Releases Wiki Activity

Make GRAPHIC select the text plane
Some checks failed
akbasic CI Build / cmake_build (push) Failing after 3m22s
Details
akbasic CI Build / sanitizers (push) Failing after 4m43s
Details
akbasic CI Build / coverage (push) Failing after 3m43s
Details
akbasic CI Build / akgl_build (push) Failing after 4m48s
Details
akbasic CI Build / mutation_test (push) Failing after 3m31s
Details

Browse Source 
Co-authored-by: Andrew Kesterson <andrew@aklabs.net>
This commit is contained in:
Tachikoma
2026-08-03 08:08:34 -04:00
parent c5d13f00f6
commit 3342f2b569
13 changed files with 345 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/runtime_graphics.c
View File

@@ -155,24 +155,24 @@ static akerr_ErrorContext *draw_line(akbasic_Runtime *obj, double x1, double y1,
akerr_ErrorContext *akbasic_cmd_graphic(akbasic_Runtime *obj, akbasic_ASTLeaf *expr, akbasic_Value *lval, akbasic_Value *rval, akbasic_Value **dest)
{
PREPARE_ERROR(errctx);
double args[2];
double args[3];
int count = 0;
int mode = 0;
int split = -1;
akbasic_Color background;
(void)lval; (void)rval;
PASS(errctx, require_graphics(obj, "GRAPHIC"));
PASS(errctx, akbasic_args_numbers(obj, expr, "GRAPHIC", args, 2, &count));
PASS(errctx, akbasic_args_numbers(obj, expr, "GRAPHIC", args, 3, &count));
FAIL_ZERO_RETURN(errctx, (count >= 1), AKBASIC_ERR_SYNTAX, "GRAPHIC expected a mode");
mode = (int)args[0];
/*
* BASIC 7.0 numbers five modes plus a CLR. They differ in bitmap resolution
* and in whether the bottom of the screen stays text, neither of which means
* anything against a host's renderer -- so the mode is recorded and only its
* one observable consequence is honoured: mode 0 is text, and text mode does
* not draw. Refusing an out-of-range mode still matters, because that is a
* typo the program author can fix.
* and in whether the bottom of the screen stays text. Resolution belongs to
* the graphics backend, while the latter is a text-sink decision: an AKGL
* sink hides its text plane for a full bitmap and moves it below the split.
* A stream has no plane, so it simply leaves that optional entry point NULL.
*/
FAIL_ZERO_RETURN(errctx, (mode >= 0 && mode <= 5), AKBASIC_ERR_BOUNDS,
"GRAPHIC mode %d out of range (0 to 5)", mode);
@@ -180,11 +180,22 @@ akerr_ErrorContext *akbasic_cmd_graphic(akbasic_Runtime *obj, akbasic_ASTLeaf *e
/* GRAPHIC CLR: drop the saved shapes and go back to text. */
PASS(errctx, obj->graphics->free_shapes(obj->graphics));
PASS(errctx, akbasic_graphics_state_init(&obj->gfx));
if ( obj->sink != NULL && obj->sink->graphic != NULL ) {
PASS(errctx, obj->sink->graphic(obj->sink, 0, -1));
}
SUCCEED_TRUE(obj, dest);
SUCCEED_RETURN(errctx);
}
if ( count >= 3 ) {
split = (int)args[2];
FAIL_ZERO_RETURN(errctx, (split >= 0 && split <= 25), AKBASIC_ERR_BOUNDS,
"GRAPHIC split %d out of range (0 to 25)", split);
}
obj->gfx.mode = mode;
if ( obj->sink != NULL && obj->sink->graphic != NULL ) {
PASS(errctx, obj->sink->graphic(obj->sink, mode, split));
}
if ( count >= 2 && args[1] != 0.0 ) {
PASS(errctx, akbasic_graphics_source_color(&obj->gfx, 0, &background));
PASS(errctx, obj->graphics->clear(obj->graphics, background));