andrew/akbasic
1
0
Fork 0
Code Issues 34 Pull Requests 2 Actions 5 Packages Projects Releases Wiki Activity

Stop pointer parameters leaking value-pool slots #43

Merged
andrew merged 4 commits from 36 into main 2026-08-06 12:38:29 -04:00
Conversation 9 Commits 4 Files Changed 7 +116 -12
logikoma commented 2026-08-04 23:10:30 -04:00
Collaborator
Copy Link

Fixes #36

Pointer parameters now create their call variable without generic storage, then keep the one-slot reference inline. By-value structure parameters retain pool-backed copies because the parameter may escape through POINT.

Tests: cmake --build build --parallel 2; ctest --test-dir build --output-on-failure (112/112 passed).

Fixes #36 Pointer parameters now create their call variable without generic storage, then keep the one-slot reference inline. By-value structure parameters retain pool-backed copies because the parameter may escape through POINT. Tests: cmake --build build --parallel 2; ctest --test-dir build --output-on-failure (112/112 passed).
logikoma added 1 commit 2026-08-04 23:10:31 -04:00
Stop pointer parameters leaking value-pool slots
All checks were successful
akbasic CI Build / cmake_build (push) Successful in 3m54s
Details
akbasic CI Build / coverage (push) Successful in 4m10s
Details
akbasic CI Build / sanitizers (push) Successful in 5m16s
Details
akbasic CI Build / akgl_build (push) Successful in 9m43s
Details
akbasic CI Build / mutation_test (push) Successful in 24m33s
Details
2e60e26b2f 
Create structure parameters before allocating their representation, then keep pointer references in the call variable's inline slot. Add an 8,000-call regression and document the remaining by-value structure escape limitation.

Co-authored-by: andrew <andrew@aklabs.net>
Co-authored-by: OpenAI Codex (GPT-5) <noreply@openai.com>
logikoma requested review from andrew 2026-08-04 23:10:35 -04:00
andrew commented 2026-08-04 23:16:16 -04:00
Owner
Copy Link

@logikoma none of your new functions in src/runtime.c have doxygen blocks explaining them, please fix

@logikoma none of your new functions in src/runtime.c have doxygen blocks explaining them, please fix
👀 1
andrew reviewed 2026-08-05 09:11:53 -04:00
src/environment.c Outdated
@@ -346,3 +349,4 @@
SUCCEED_RETURN(errctx);
}
akerr_ErrorContext *akbasic_environment_create(akbasic_Environment *obj, const char *varname, akbasic_Variable **dest)
andrew commented 2026-08-05 09:11:53 -04:00
Owner
Copy Link

@logikoma None of these new functions in src/environment.c have doxygen blocks, fix it

@logikoma None of these new functions in src/environment.c have doxygen blocks, fix it
andrew commented 2026-08-05 09:17:10 -04:00
Owner
Copy Link

@tachikoma none of the new function definitions here have doxygen blocks can you fix it

@tachikoma none of the new function definitions here have doxygen blocks can you fix it
👀 1
andrew commented 2026-08-05 11:26:16 -04:00
Owner
Copy Link

@tachikoma none of the new function definitions here have doxygen blocks can you fix it

@tachikoma none of the new function definitions here have doxygen blocks can you fix it
👀 1
tachikoma added 1 commit 2026-08-05 11:49:54 -04:00
Add doxygen block for environment_create_named
Some checks failed
akbasic CI Build / sanitizers (push) Failing after 33s
Details
akbasic CI Build / cmake_build (push) Failing after 39s
Details
akbasic CI Build / coverage (push) Failing after 37s
Details
akbasic CI Build / akgl_build (push) Failing after 17s
Details
akbasic CI Build / mutation_test (push) Failing after 17s
Details
d29b1ace8f 
Andrew flagged the new helper introduced for the value-pool-leak fix
as missing documentation. akbasic_environment_create() and
akbasic_environment_create_empty() are already documented in the
header; the shared static helper they both call was the only
undocumented new function definition.

Co-authored-by: andrew <andrew@aklabs.net>
tachikoma commented 2026-08-05 11:49:55 -04:00
Collaborator
Copy Link

Added a doxygen block for environment_create_named (the only new function definition in src/environment.c that wasn't already documented — akbasic_environment_create() and akbasic_environment_create_empty() are documented in the header). Pushed as d29b1ac.

Added a doxygen block for environment_create_named (the only new function definition in src/environment.c that wasn't already documented — akbasic_environment_create() and akbasic_environment_create_empty() are documented in the header). Pushed as d29b1ac.
andrew force-pushed 36 from d29b1ace8f to ec4a2c23d7 2026-08-05 11:52:34 -04:00 Compare
andrew commented 2026-08-05 12:10:22 -04:00
Owner
Copy Link

@logikoma the pipeline is failing

@logikoma the pipeline is failing
👀 1
logikoma was assigned by andrew 2026-08-05 15:07:32 -04:00
logikoma added 1 commit 2026-08-05 17:05:31 -04:00
Document environment variable creation helpers
Some checks failed
akbasic CI Build / cmake_build (push) Has been cancelled
Details
akbasic CI Build / sanitizers (push) Has been cancelled
Details
akbasic CI Build / coverage (push) Has been cancelled
Details
akbasic CI Build / akgl_build (push) Has been cancelled
Details
akbasic CI Build / mutation_test (push) Has been cancelled
Details
ebec1f1621
logikoma commented 2026-08-05 17:05:55 -04:00
Author
Collaborator
Copy Link

Added Doxygen blocks for the new environment variable creation helper and both public wrappers. Build and all 112 tests pass.

Added Doxygen blocks for the new environment variable creation helper and both public wrappers. Build and all 112 tests pass.
andrew commented 2026-08-06 12:11:16 -04:00
Owner
Copy Link

@logikoma SIGN ALL COMMITS ON THIS PULL REQUEST

@logikoma SIGN ALL COMMITS ON THIS PULL REQUEST
👀 1
logikoma force-pushed 36 from ebec1f1621 to 5c04edc5fb 2026-08-06 12:34:10 -04:00 Compare
logikoma commented 2026-08-06 12:34:19 -04:00
Author
Collaborator
Copy Link

Rebuilt all three commits with Logikoma SSH signatures and force-pushed branch 36. Each commit verifies locally as G; the resulting tree is byte-for-byte unchanged. The requested Doxygen block remains in the second commit.

Rebuilt all three commits with Logikoma SSH signatures and force-pushed branch 36. Each commit verifies locally as G; the resulting tree is byte-for-byte unchanged. The requested Doxygen block remains in the second commit.
andrew added 1 commit 2026-08-06 12:38:12 -04:00
Merge branch 'main' into 36
Some checks are pending
akbasic CI Build / mutation_test (push) Waiting to run
Details
akbasic CI Build / cmake_build (push) Successful in 3m25s
Details
akbasic CI Build / coverage (push) Successful in 4m18s
Details
akbasic CI Build / sanitizers (push) Successful in 5m4s
Details
akbasic CI Build / akgl_build (push) Successful in 8m17s
Details
39a0c60bf3
andrew merged commit bb3060b29d into main 2026-08-06 12:38:29 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
andrew
Labels
Clear labels
abi-break
Cannot land without a soname bump
 api-gap
A caller cannot express something
 blast-radius:high
Ordering: highest blast radius
 blast-radius:low
Ordering: lowest blast radius
 blast-radius:medium
Ordering: middling blast radius
 defect
Wrong behaviour reachable from the public API
 design-decision
Needs a decision written down before code
 docs
Documentation, comments, AGENTS.md
 hygiene
Style, dead code, consistency
 packaging
Build, install, pkg-config, CMake config
 performance
Has a measurement behind it
 status::blocked
Waiting on something else -- a decision, a dependency, or another issue
 status::grooming
Not yet worked out: scope, approach or priority still being settled
 status::ready
Understood well enough to start: scope and approach are settled
 status::review
A pull request has been generated and this ticket is waiting on review of that PR
 test-coverage
A gap in the suites, not a defect
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
logikoma tachikoma andrew
No Assignees logikoma
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: andrew/akbasic#43
Delete Branch "36"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?