Andrew Kesterson
9845e77a5c
Closes groups A, C, D, E, F, H and J of TODO.md section 4, plus RESTORE and RENUMBER, and closes section 6 -- all seventeen reference defects. Seven of those turned out to have been fixed or never ported and nobody had written it down; the audit records the evidence for each. Two of the seventeen were real. math_plus mutated its left operand when the operand was mutable, so A# + 1 could modify A#; it was gated on FOR/NEXT coverage because NEXT relied on the mutation, so tests/for_next.c came first and NEXT now writes the counter back itself. And the binary operators summed both numeric fields of their right operand, which no BASIC program can reach -- that one needed a test written against the value API. Writing the tests turned up eight defects nobody had listed. Seven are fixed: IF A = 2 THEN was a parse error; only == worked IF ... AND ... was a parse error, because a condition parsed as one relation IF A = 1 OR B = 2 THEN was silently always false, and so was IF A THEN EXIT before any NEXT restarted the program and exhausted the variable pool READ never found a DATA line above it, and swallowed the lines between PRINT 2 + 2 at the prompt was filed as program text instead of answering a short read discarded its bytes, so COPY produced empty files every verb taking an argument list said "peek() returned nil token!" on none The eighth is not fixed and cannot be quietly: a FOR whose step overshoots runs its body one extra time, and FOR I = 1 TO 1 runs it zero times. The two errors cancel for a step of 1, which is why neither was noticed. Correcting them changes the expected output of a checked-in acceptance file, and tests/reference/README.md forbids editing one to suit this interpreter. It is tests/for_semantics.c in AKBASIC_KNOWN_FAILING_TESTS, asserting the correct contract, and TODO.md items 19 and 20. Sprites are real libakgl actors with a renderfunc of their own, because akgl_actor_render draws every sprite square and an actor has no per-axis scale. Both are filed upstream. SPRSAV takes an image file, an SSHAPE handle or a 63-element integer array -- a string here cannot hold a zero byte. Verbs that need hardware that does not exist are refused by name with the reason rather than faked: SYS, HEADER, COLLECT, BACKUP, BOOT, FILTER, and DIRECTORY, which is refused for a missing libakstdlib wrapper filed upstream. 94 tests in the default build, 93 with SDL, 94 under ASan and UBSan, doxygen clean. The Go acceptance corpus stayed green throughout. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
96 lines
3.5 KiB
C
96 lines
3.5 KiB
C
/**
|
|
* @file verbs_table.c
|
|
* @brief Tests the dispatch table's invariants.
|
|
*
|
|
* The sorting assertion is the important one: bsearch on a mis-sorted table
|
|
* silently fails to find a verb rather than producing a compile error, and the
|
|
* symptom would be "Unknown command PRINT" a long way from the cause.
|
|
*/
|
|
|
|
#include <string.h>
|
|
|
|
#include <akbasic/error.h>
|
|
#include <akbasic/verbs.h>
|
|
|
|
#include "testutil.h"
|
|
|
|
int main(void)
|
|
{
|
|
const akbasic_Verb *table = NULL;
|
|
const akbasic_Verb *found = NULL;
|
|
int count = 0;
|
|
int i = 0;
|
|
|
|
TEST_REQUIRE_OK(akbasic_error_register());
|
|
|
|
table = akbasic_verb_table(&count);
|
|
TEST_REQUIRE(table != NULL, "the verb table must exist");
|
|
TEST_REQUIRE(count > 0, "the verb table must not be empty");
|
|
|
|
/* Sorted, strictly: bsearch requires it and a duplicate name is a bug. */
|
|
for ( i = 1; i < count; i++ ) {
|
|
TEST_REQUIRE(strcmp(table[i - 1].name, table[i].name) < 0,
|
|
"table is not sorted at index %d: \"%s\" then \"%s\"",
|
|
i, table[i - 1].name, table[i].name);
|
|
}
|
|
|
|
/* Every row is reachable by its own name. */
|
|
for ( i = 0; i < count; i++ ) {
|
|
TEST_REQUIRE_OK(akbasic_verb_lookup(table[i].name, &found));
|
|
TEST_REQUIRE(found == &table[i], "row \"%s\" is not findable", table[i].name);
|
|
}
|
|
|
|
/* Verbs and function names are case-insensitive; variable names are not. */
|
|
TEST_REQUIRE_OK(akbasic_verb_lookup("print", &found));
|
|
TEST_REQUIRE(found != NULL && strcmp(found->name, "PRINT") == 0, "lowercase print missed");
|
|
TEST_REQUIRE_OK(akbasic_verb_lookup("PrInT", &found));
|
|
TEST_REQUIRE(found != NULL && strcmp(found->name, "PRINT") == 0, "mixed-case print missed");
|
|
|
|
/* A miss is a NULL, not an error. */
|
|
TEST_REQUIRE_OK(akbasic_verb_lookup("NOTAVERB", &found));
|
|
TEST_REQUIRE(found == NULL, "an unknown name must miss");
|
|
TEST_REQUIRE_OK(akbasic_verb_lookup("", &found));
|
|
TEST_REQUIRE(found == NULL, "an empty name must miss");
|
|
|
|
/* Every function row carries a real arity and a handler. */
|
|
for ( i = 0; i < count; i++ ) {
|
|
if ( table[i].tokentype != AKBASIC_TOK_FUNCTION ) {
|
|
continue;
|
|
}
|
|
TEST_REQUIRE(table[i].arity >= 1,
|
|
"function \"%s\" has arity %d", table[i].name, table[i].arity);
|
|
TEST_REQUIRE(table[i].exec != NULL,
|
|
"function \"%s\" has no exec handler", table[i].name);
|
|
}
|
|
|
|
/*
|
|
* These rows have no exec handler because another verb's parse path consumes
|
|
* them; they are never evaluated on their own. `WHILE` and `UNTIL` belong to
|
|
* DO and LOOP the way `TO` and `STEP` belong to FOR. Any other missing
|
|
* handler is a verb that would report "Unknown command" at runtime.
|
|
*/
|
|
for ( i = 0; i < count; i++ ) {
|
|
if ( table[i].exec != NULL ) {
|
|
continue;
|
|
}
|
|
TEST_REQUIRE(strcmp(table[i].name, "AND") == 0 ||
|
|
strcmp(table[i].name, "ELSE") == 0 ||
|
|
strcmp(table[i].name, "NOT") == 0 ||
|
|
strcmp(table[i].name, "OR") == 0 ||
|
|
strcmp(table[i].name, "REM") == 0 ||
|
|
strcmp(table[i].name, "STEP") == 0 ||
|
|
strcmp(table[i].name, "UNTIL") == 0 ||
|
|
strcmp(table[i].name, "USING") == 0 ||
|
|
strcmp(table[i].name, "WHILE") == 0 ||
|
|
strcmp(table[i].name, "THEN") == 0 ||
|
|
strcmp(table[i].name, "TO") == 0,
|
|
"verb \"%s\" has no exec handler and is not a known passive token",
|
|
table[i].name);
|
|
}
|
|
|
|
TEST_REQUIRE_STATUS(akbasic_verb_lookup(NULL, &found), AKERR_NULLPOINTER);
|
|
TEST_REQUIRE_STATUS(akbasic_verb_lookup("PRINT", NULL), AKERR_NULLPOINTER);
|
|
|
|
return akbasic_test_failures;
|
|
}
|