Closes groups A, C, D, E, F, H and J of TODO.md section 4, plus RESTORE and RENUMBER, and closes section 6 -- all seventeen reference defects. Seven of those turned out to have been fixed or never ported and nobody had written it down; the audit records the evidence for each. Two of the seventeen were real. math_plus mutated its left operand when the operand was mutable, so A# + 1 could modify A#; it was gated on FOR/NEXT coverage because NEXT relied on the mutation, so tests/for_next.c came first and NEXT now writes the counter back itself. And the binary operators summed both numeric fields of their right operand, which no BASIC program can reach -- that one needed a test written against the value API. Writing the tests turned up eight defects nobody had listed. Seven are fixed: IF A = 2 THEN was a parse error; only == worked IF ... AND ... was a parse error, because a condition parsed as one relation IF A = 1 OR B = 2 THEN was silently always false, and so was IF A THEN EXIT before any NEXT restarted the program and exhausted the variable pool READ never found a DATA line above it, and swallowed the lines between PRINT 2 + 2 at the prompt was filed as program text instead of answering a short read discarded its bytes, so COPY produced empty files every verb taking an argument list said "peek() returned nil token!" on none The eighth is not fixed and cannot be quietly: a FOR whose step overshoots runs its body one extra time, and FOR I = 1 TO 1 runs it zero times. The two errors cancel for a step of 1, which is why neither was noticed. Correcting them changes the expected output of a checked-in acceptance file, and tests/reference/README.md forbids editing one to suit this interpreter. It is tests/for_semantics.c in AKBASIC_KNOWN_FAILING_TESTS, asserting the correct contract, and TODO.md items 19 and 20. Sprites are real libakgl actors with a renderfunc of their own, because akgl_actor_render draws every sprite square and an actor has no per-axis scale. Both are filed upstream. SPRSAV takes an image file, an SSHAPE handle or a 63-element integer array -- a string here cannot hold a zero byte. Verbs that need hardware that does not exist are refused by name with the reason rather than faked: SYS, HEADER, COLLECT, BACKUP, BOOT, FILTER, and DIRECTORY, which is refused for a missing libakstdlib wrapper filed upstream. 94 tests in the default build, 93 with SDL, 94 under ASan and UBSan, doxygen clean. The Go acceptance corpus stayed green throughout. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-Authored-By: Andrew Kesterson <andrew@aklabs.net>
74 lines
2.7 KiB
C
74 lines
2.7 KiB
C
/**
|
|
* @file console.h
|
|
* @brief The group E console state: SLEEP, WAIT, KEY and the TI clock.
|
|
*
|
|
* All of it is the program's state rather than the device's, which is why it
|
|
* lives on the runtime beside the graphics, audio and sprite state. A host that
|
|
* swaps one output device for another does not expect a sleeping program to wake
|
|
* up or its function keys to be forgotten.
|
|
*/
|
|
|
|
#ifndef _AKBASIC_CONSOLE_H_
|
|
#define _AKBASIC_CONSOLE_H_
|
|
|
|
#include <akerror.h>
|
|
|
|
#include <akbasic/types.h>
|
|
|
|
/** @brief Function keys `KEY` can define. A C128 has eight. */
|
|
#define AKBASIC_MAX_FUNCTION_KEYS 8
|
|
|
|
/** @brief The state SLEEP, WAIT and KEY keep. */
|
|
typedef struct
|
|
{
|
|
bool sleeping; /** SLEEP is holding the step loop */
|
|
int64_t sleepuntilms; /** ...until the host clock reaches this */
|
|
|
|
bool waiting; /** WAIT is holding the step loop */
|
|
uintptr_t waitaddress; /** the byte it is polling */
|
|
uint8_t waitmask;
|
|
uint8_t waitxor;
|
|
|
|
char keys[AKBASIC_MAX_FUNCTION_KEYS][AKBASIC_MAX_STRING_LENGTH];
|
|
} akbasic_ConsoleState;
|
|
|
|
struct akbasic_Runtime;
|
|
|
|
/**
|
|
* @brief Reset the console state: nothing sleeping, nothing waiting, no macros.
|
|
* @param obj Object to initialize, inspect, or modify.
|
|
* @return `NULL` on success, otherwise an error context owned by the caller.
|
|
* @throws AKERR_NULLPOINTER When `obj` is NULL.
|
|
*/
|
|
akerr_ErrorContext AKERR_NOIGNORE *akbasic_console_state_init(akbasic_ConsoleState *obj);
|
|
|
|
/**
|
|
* @brief Answer whether a SLEEP or a WAIT is still holding the step loop.
|
|
*
|
|
* Called once per akbasic_runtime_step(), beside akbasic_input_service() and for
|
|
* the same reason: waiting must not mean blocking. The step still returns, it
|
|
* simply does not advance the program.
|
|
*
|
|
* @param obj Object to initialize, inspect, or modify.
|
|
* @param blocked Output destination populated by the function; true while held.
|
|
* @return `NULL` on success, otherwise an error context owned by the caller.
|
|
* @throws AKERR_NULLPOINTER When either argument is NULL.
|
|
*/
|
|
akerr_ErrorContext AKERR_NOIGNORE *akbasic_console_service(struct akbasic_Runtime *obj, bool *blocked);
|
|
|
|
/**
|
|
* @brief Refresh `TI#` and `TI$` from the host's clock.
|
|
*
|
|
* Called once per step. They are ordinary global variables rather than
|
|
* pseudo-variables, because this dialect has no bare variable names -- see
|
|
* TODO.md section 5.
|
|
*
|
|
* @param obj Object to initialize, inspect, or modify.
|
|
* @return `NULL` on success, otherwise an error context owned by the caller.
|
|
* @throws AKERR_NULLPOINTER When `obj` is NULL.
|
|
* @throws AKBASIC_ERR_BOUNDS When no variable slot is free.
|
|
*/
|
|
akerr_ErrorContext AKERR_NOIGNORE *akbasic_console_update_clock(struct akbasic_Runtime *obj);
|
|
|
|
#endif // _AKBASIC_CONSOLE_H_
|