Tachikoma
4e188b2794
Reproduces deps/basicinterpret in C, in the idiom of the ak* libraries. All 41
.bas files in the reference's corpus produce byte-identical stdout, including
the trailing double newline on an error line -- that comes from basicError
building a string ending in \n and handing it to Println, and
array_outofbounds.txt encodes it.
The corpus is driven in place from the submodule as 41 individual CTest cases
rather than copied, so it cannot drift from upstream. Eighteen unit tests cover
what the corpus cannot reach.
Three structural changes carry most of the work. Go's three reflection lookups
(Command*, Function*, ParseCommand*) become one sorted dispatch table in
src/verbs.c searched with bsearch; adding a verb is a row and two functions. The
five Go maps become one fixed open-addressed table over aksl_strhash_djb2. And
run(), which owned the process until MODE_QUIT, splits into step() plus a
bounded run() -- goal 3 requires a host game to be able to bound execution, and
nothing in the library now terminates the process or touches SDL.
Output goes through an akbasic_TextSink vtable. src/sink_stdio.c is what makes
the corpus runnable with no SDL present; the akgl-backed sink is still to come
and is blocked on libakgl having no text-measurement call.
src/convert.c exists because libakstdlib's aksl_ato* family cannot report a
conversion failure (its TODO.md 2.1.5). The reference checks strconv's error at
four sites and turns it into a BASIC error; routing those through aksl_atoi
would have turned four diagnosable errors into wrong answers, with VAL("garbage")
quietly returning 0. TODO.md 1.9 records which libakstdlib calls are cleared for
use here and which are not.
Reference defects are reproduced, not fixed: the golden files encode the observed
behaviour and a silent correction is a behaviour change. TODO.md section 6 lists
sixteen, and tests/known_reference_defects.c asserts the *correct* contract for
six of them under AKBASIC_KNOWN_FAILING_TESTS, so a fix shows up as
"unexpectedly passed". Five of the sixteen were found by this port and are new:
subtraction stops after one operator so 1-2-3 computes 1-2 and abandons the rest
of the line (a wrong answer, not a refused one); a unary-minus argument inflates
a function's arity so ABS(-9) is rejected; a comparison operator in a line's
final column is dropped; hex literals never survive the scanner; and the
"Reserved word in variable name" check is dead code.
Where the reference reaches undefined behaviour by a route that is defined in Go
-- an out-of-range shift, a negative string multiplier, integer division by zero
-- this raises instead of inheriting the UB. No golden case exercises any of
them.
The top-level CMakeLists shadows add_test, set_tests_properties and
add_custom_target around all three add_subdirectory calls. Without it libakerror's
tests land in our suite as Not Run, and its un-namespaced `coverage` target stops
a coverage build from configuring at all. Test targets are akbasic_test_<name>:
bare test_<name> collides with libakstdlib's, which is what broke libakgl's
configure in c2b16d3.
ctest 59/59; ASan+UBSan 59/59; 92.3% line and 96.9% function coverage; no
warnings under -Wall -Wextra. Branch coverage is not a target, for the reason
libakstdlib and libakgl both record: the akerror macros expand into large branch
trees at every call site.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Andrew Kesterson <andrew@aklabs.net>
88 lines
3.1 KiB
C
88 lines
3.1 KiB
C
/**
|
|
* @file symtab.h
|
|
* @brief Declares a fixed-capacity open-addressed string-keyed table.
|
|
*
|
|
* The Go reference used five maps. Three of them -- an environment's variables,
|
|
* functions and labels -- become this: one implementation, capacity supplied by
|
|
* the caller, keyed by aksl_strhash_djb2 with linear probing. A full table is an
|
|
* error, not a resize.
|
|
*/
|
|
|
|
#ifndef _AKBASIC_SYMTAB_H_
|
|
#define _AKBASIC_SYMTAB_H_
|
|
|
|
#include <stdbool.h>
|
|
#include <stdint.h>
|
|
|
|
#include <akerror.h>
|
|
|
|
#include <akbasic/types.h>
|
|
|
|
/*
|
|
* Slots are sized for the largest table any caller needs, so one slot array type
|
|
* serves variables, functions and labels. Capacity is a member; the table is
|
|
* kept below a 75% load factor by construction because `capacity` counts slots
|
|
* and the caller's logical maximum is smaller.
|
|
*/
|
|
#define AKBASIC_SYMTAB_MAX_SLOTS 256
|
|
#define AKBASIC_SYMTAB_MAX_KEY 64
|
|
|
|
typedef struct
|
|
{
|
|
bool used;
|
|
char key[AKBASIC_SYMTAB_MAX_KEY];
|
|
void *value;
|
|
int64_t ivalue;
|
|
} akbasic_SymbolSlot;
|
|
|
|
typedef struct
|
|
{
|
|
int capacity;
|
|
int count;
|
|
akbasic_SymbolSlot slots[AKBASIC_SYMTAB_MAX_SLOTS];
|
|
} akbasic_SymbolTable;
|
|
|
|
/**
|
|
* @brief Symbol table initialize.
|
|
* @param obj Object to initialize, inspect, or modify.
|
|
* @param capacity Number of slots to use; must be positive and no larger than AKBASIC_SYMTAB_MAX_SLOTS.
|
|
* @return `NULL` on success, otherwise an error context owned by the caller.
|
|
* @throws AKERR_NULLPOINTER When `obj` is NULL.
|
|
* @throws AKBASIC_ERR_BOUNDS When `capacity` is out of range.
|
|
*/
|
|
akerr_ErrorContext AKERR_NOIGNORE *akbasic_symtab_init(akbasic_SymbolTable *obj, int capacity);
|
|
|
|
/**
|
|
* @brief Store a pointer and an integer against a key, replacing any existing entry.
|
|
* @param obj Object to initialize, inspect, or modify.
|
|
* @param key Lookup key; copied into the slot.
|
|
* @param value Pointer payload, may be NULL.
|
|
* @param ivalue Integer payload, used by the label table.
|
|
* @return `NULL` on success, otherwise an error context owned by the caller.
|
|
* @throws AKERR_NULLPOINTER When `obj` or `key` is NULL.
|
|
* @throws AKBASIC_ERR_BOUNDS When the key is too long or the table is full.
|
|
*/
|
|
akerr_ErrorContext AKERR_NOIGNORE *akbasic_symtab_set(akbasic_SymbolTable *obj, const char *key, void *value, int64_t ivalue);
|
|
|
|
/**
|
|
* @brief Look a key up.
|
|
* @param obj Object to initialize, inspect, or modify.
|
|
* @param key Lookup key.
|
|
* @param value Output destination for the pointer payload; may be NULL.
|
|
* @param ivalue Output destination for the integer payload; may be NULL.
|
|
* @return `NULL` on success, otherwise an error context owned by the caller.
|
|
* @throws AKERR_NULLPOINTER When `obj` or `key` is NULL.
|
|
* @throws AKERR_KEY When the key is not present.
|
|
*/
|
|
akerr_ErrorContext AKERR_NOIGNORE *akbasic_symtab_get(akbasic_SymbolTable *obj, const char *key, void **value, int64_t *ivalue);
|
|
|
|
/**
|
|
* @brief Drop every entry.
|
|
* @param obj Object to initialize, inspect, or modify.
|
|
* @return `NULL` on success, otherwise an error context owned by the caller.
|
|
* @throws AKERR_NULLPOINTER When `obj` is NULL.
|
|
*/
|
|
akerr_ErrorContext AKERR_NOIGNORE *akbasic_symtab_clear(akbasic_SymbolTable *obj);
|
|
|
|
#endif // _AKBASIC_SYMTAB_H_
|