Tachikoma
4e7d2cff6c
Closes groups A, C, D, E, F, H and J of TODO.md section 4, plus RESTORE and RENUMBER, and closes section 6 -- all seventeen reference defects. Seven of those turned out to have been fixed or never ported and nobody had written it down; the audit records the evidence for each. Two of the seventeen were real. math_plus mutated its left operand when the operand was mutable, so A# + 1 could modify A#; it was gated on FOR/NEXT coverage because NEXT relied on the mutation, so tests/for_next.c came first and NEXT now writes the counter back itself. And the binary operators summed both numeric fields of their right operand, which no BASIC program can reach -- that one needed a test written against the value API. Writing the tests turned up eight defects nobody had listed. Seven are fixed: IF A = 2 THEN was a parse error; only == worked IF ... AND ... was a parse error, because a condition parsed as one relation IF A = 1 OR B = 2 THEN was silently always false, and so was IF A THEN EXIT before any NEXT restarted the program and exhausted the variable pool READ never found a DATA line above it, and swallowed the lines between PRINT 2 + 2 at the prompt was filed as program text instead of answering a short read discarded its bytes, so COPY produced empty files every verb taking an argument list said "peek() returned nil token!" on none The eighth is not fixed and cannot be quietly: a FOR whose step overshoots runs its body one extra time, and FOR I = 1 TO 1 runs it zero times. The two errors cancel for a step of 1, which is why neither was noticed. Correcting them changes the expected output of a checked-in acceptance file, and tests/reference/README.md forbids editing one to suit this interpreter. It is tests/for_semantics.c in AKBASIC_KNOWN_FAILING_TESTS, asserting the correct contract, and TODO.md items 19 and 20. Sprites are real libakgl actors with a renderfunc of their own, because akgl_actor_render draws every sprite square and an actor has no per-axis scale. Both are filed upstream. SPRSAV takes an image file, an SSHAPE handle or a 63-element integer array -- a string here cannot hold a zero byte. Verbs that need hardware that does not exist are refused by name with the reason rather than faked: SYS, HEADER, COLLECT, BACKUP, BOOT, FILTER, and DIRECTORY, which is refused for a missing libakstdlib wrapper filed upstream. 94 tests in the default build, 93 with SDL, 94 under ASan and UBSan, doxygen clean. The Go acceptance corpus stayed green throughout. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-Authored-By: Andrew Kesterson <andrew@aklabs.net>
47 lines
1.8 KiB
C
47 lines
1.8 KiB
C
/**
|
|
* @file args.h
|
|
* @brief Collecting a verb's positional arguments, shared by the verb files.
|
|
*
|
|
* Every device verb group -- graphics, audio, and now sprites -- takes a short
|
|
* positional list with optional trailing members, so every handler wants the
|
|
* same two things: how many arguments arrived, and their numeric values. This
|
|
* was written twice before it was written here. src/runtime_audio.c's copy
|
|
* carried the rule for when to stop copying it:
|
|
*
|
|
* "If a third group wants it, that is the point at which it earns a home of
|
|
* its own."
|
|
*
|
|
* Group H is the third group.
|
|
*/
|
|
|
|
#ifndef _AKBASIC_ARGS_H_
|
|
#define _AKBASIC_ARGS_H_
|
|
|
|
#include <akerror.h>
|
|
|
|
#include <akbasic/grammar.h>
|
|
|
|
struct akbasic_Runtime;
|
|
|
|
/**
|
|
* @brief Collect a verb's arguments into an array, evaluating each one.
|
|
*
|
|
* Strings are refused here rather than in each verb. A verb that does take one
|
|
* -- SSHAPE, GSHAPE, SPRSAV -- reads its leaf directly instead, because what it
|
|
* wants from that argument is not a number and never was.
|
|
*
|
|
* @param obj Runtime to evaluate against.
|
|
* @param expr The command leaf.
|
|
* @param verb Name to use in a diagnostic; a verb that refuses has to say which.
|
|
* @param values Where to put the evaluated arguments.
|
|
* @param max Capacity of @p values.
|
|
* @param count Output destination populated by the function.
|
|
* @return `NULL` on success, otherwise an error context owned by the caller.
|
|
* @throws AKERR_NULLPOINTER When any argument but `verb` is NULL.
|
|
* @throws AKBASIC_ERR_SYNTAX When more than `max` arguments were given.
|
|
* @throws AKBASIC_ERR_TYPE When an argument evaluated to a string.
|
|
*/
|
|
akerr_ErrorContext AKERR_NOIGNORE *akbasic_args_numbers(struct akbasic_Runtime *obj, akbasic_ASTLeaf *expr, const char *verb, double *values, int max, int *count);
|
|
|
|
#endif // _AKBASIC_ARGS_H_
|