Tachikoma
4e7d2cff6c
Closes groups A, C, D, E, F, H and J of TODO.md section 4, plus RESTORE and RENUMBER, and closes section 6 -- all seventeen reference defects. Seven of those turned out to have been fixed or never ported and nobody had written it down; the audit records the evidence for each. Two of the seventeen were real. math_plus mutated its left operand when the operand was mutable, so A# + 1 could modify A#; it was gated on FOR/NEXT coverage because NEXT relied on the mutation, so tests/for_next.c came first and NEXT now writes the counter back itself. And the binary operators summed both numeric fields of their right operand, which no BASIC program can reach -- that one needed a test written against the value API. Writing the tests turned up eight defects nobody had listed. Seven are fixed: IF A = 2 THEN was a parse error; only == worked IF ... AND ... was a parse error, because a condition parsed as one relation IF A = 1 OR B = 2 THEN was silently always false, and so was IF A THEN EXIT before any NEXT restarted the program and exhausted the variable pool READ never found a DATA line above it, and swallowed the lines between PRINT 2 + 2 at the prompt was filed as program text instead of answering a short read discarded its bytes, so COPY produced empty files every verb taking an argument list said "peek() returned nil token!" on none The eighth is not fixed and cannot be quietly: a FOR whose step overshoots runs its body one extra time, and FOR I = 1 TO 1 runs it zero times. The two errors cancel for a step of 1, which is why neither was noticed. Correcting them changes the expected output of a checked-in acceptance file, and tests/reference/README.md forbids editing one to suit this interpreter. It is tests/for_semantics.c in AKBASIC_KNOWN_FAILING_TESTS, asserting the correct contract, and TODO.md items 19 and 20. Sprites are real libakgl actors with a renderfunc of their own, because akgl_actor_render draws every sprite square and an actor has no per-axis scale. Both are filed upstream. SPRSAV takes an image file, an SSHAPE handle or a 63-element integer array -- a string here cannot hold a zero byte. Verbs that need hardware that does not exist are refused by name with the reason rather than faked: SYS, HEADER, COLLECT, BACKUP, BOOT, FILTER, and DIRECTORY, which is refused for a missing libakstdlib wrapper filed upstream. 94 tests in the default build, 93 with SDL, 94 under ASan and UBSan, doxygen clean. The Go acceptance corpus stayed green throughout. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-Authored-By: Andrew Kesterson <andrew@aklabs.net>
93 lines
3.7 KiB
C
93 lines
3.7 KiB
C
/**
|
|
* @file format.h
|
|
* @brief `PRINT USING` field formatting, and the `PUDEF` characters it fills with.
|
|
*
|
|
* Its own translation unit rather than a helper inside the PRINT handler,
|
|
* because the interesting part is a pure function of a format string and a
|
|
* value: it can be tested exhaustively without a runtime, a sink or a program,
|
|
* and field formatting has far more edge cases than a verb usually does.
|
|
*/
|
|
|
|
#ifndef _AKBASIC_FORMAT_H_
|
|
#define _AKBASIC_FORMAT_H_
|
|
|
|
#include <akerror.h>
|
|
|
|
#include <akbasic/types.h>
|
|
#include <akbasic/value.h>
|
|
|
|
/** @brief How many characters `PUDEF` can redefine. */
|
|
#define AKBASIC_PUDEF_CHARS 4
|
|
|
|
/** @brief `PUDEF` position 1: what a leading blank in a numeric field is filled with. */
|
|
#define AKBASIC_PUDEF_BLANK 0
|
|
/** @brief `PUDEF` position 2: the thousands separator. */
|
|
#define AKBASIC_PUDEF_COMMA 1
|
|
/** @brief `PUDEF` position 3: the decimal point. */
|
|
#define AKBASIC_PUDEF_POINT 2
|
|
/** @brief `PUDEF` position 4: the currency sign. */
|
|
#define AKBASIC_PUDEF_DOLLAR 3
|
|
|
|
/**
|
|
* @brief The four characters `PUDEF` redefines.
|
|
*
|
|
* Lives on the runtime beside the other verb-group state: it is the program's,
|
|
* not the sink's, and a host that swaps one output device for another does not
|
|
* expect the program's punctuation to change.
|
|
*/
|
|
typedef struct
|
|
{
|
|
char chars[AKBASIC_PUDEF_CHARS];
|
|
} akbasic_FormatState;
|
|
|
|
/**
|
|
* @brief Reset the `PUDEF` characters to their defaults: space, comma, point, dollar.
|
|
* @param obj Object to initialize, inspect, or modify.
|
|
* @return `NULL` on success, otherwise an error context owned by the caller.
|
|
* @throws AKERR_NULLPOINTER When `obj` is NULL.
|
|
*/
|
|
akerr_ErrorContext AKERR_NOIGNORE *akbasic_format_state_init(akbasic_FormatState *obj);
|
|
|
|
/**
|
|
* @brief Redefine the fill characters, up to four of them.
|
|
*
|
|
* Positions past the end of @p chars keep whatever they had, so `PUDEF "*"`
|
|
* changes only the leading-blank character. That is BASIC 7.0's rule.
|
|
*
|
|
* @param obj Object to initialize, inspect, or modify.
|
|
* @param chars Replacement characters, in PUDEF order; at most four are read.
|
|
* @return `NULL` on success, otherwise an error context owned by the caller.
|
|
* @throws AKERR_NULLPOINTER When either argument is NULL.
|
|
*/
|
|
akerr_ErrorContext AKERR_NOIGNORE *akbasic_format_pudef(akbasic_FormatState *obj, const char *chars);
|
|
|
|
/**
|
|
* @brief Render one value into one `PRINT USING` field.
|
|
*
|
|
* @p format is the whole format string; the *first* field in it is the one used,
|
|
* and any literal text around that field is copied through. That is how BASIC
|
|
* 7.0 works -- `PRINT USING "TOTAL: ###.##"; X` prints the label as well.
|
|
*
|
|
* Numeric fields are built from `#` digit positions, an optional `.` and
|
|
* embedded `,` separators, with an optional leading or trailing `$`, `+` or `-`.
|
|
* String fields are `=` to centre and `>` to right-justify, and a bare run of
|
|
* `#` left-justifies.
|
|
*
|
|
* **A value too wide for its field fills the field with `*`**, which is BASIC
|
|
* 7.0's answer and is deliberately loud: silently printing more digits than the
|
|
* field asked for would misalign every column after it.
|
|
*
|
|
* @param obj The PUDEF characters to fill with.
|
|
* @param format The format string.
|
|
* @param value The value to render.
|
|
* @param dest Output destination populated by the function.
|
|
* @param len Capacity of @p dest, terminator included.
|
|
* @return `NULL` on success, otherwise an error context owned by the caller.
|
|
* @throws AKERR_NULLPOINTER When any argument is NULL.
|
|
* @throws AKBASIC_ERR_BOUNDS When the result does not fit @p dest.
|
|
* @throws AKBASIC_ERR_SYNTAX When the format string contains no field at all.
|
|
*/
|
|
akerr_ErrorContext AKERR_NOIGNORE *akbasic_format_using(akbasic_FormatState *obj, const char *format, akbasic_Value *value, char *dest, size_t len);
|
|
|
|
#endif // _AKBASIC_FORMAT_H_
|