andrew/cmdarg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Compare commits

base: andrew:feature/cmdarg_dump_argv
Branches Tags
andrew:master andrew:feature/cmdarg_dump_argv andrew:neechbear-master andrew:refi64-fix_ret andrew:zaneduffield-PR29 andrew:break_tests
..
compare: andrew:zaneduffield-PR29
Branches Tags
andrew:master andrew:feature/cmdarg_dump_argv andrew:neechbear-master andrew:refi64-fix_ret andrew:zaneduffield-PR29 andrew:break_tests

7 Commits
feature/cm ... zaneduffie

Author SHA1 Message Date
Zane Duffield
994b076174 Simply copyright and author header components when empty
Some checks failed
CI with JUnit Report / build-and-test (push) Has been cancelled
Details
2026-01-18 12:21:50 -05:00
Zane Duffield
7aedd40945 Add .shellcheckrc to silence lints 2026-01-18 12:21:50 -05:00
Zane Duffield
4bff72f4d2 Fix misc shellcheck issues 
* make clear that array expansion was not desired in one case
* change `$@` to `$*` in one case
* remove unnecessary `$` in arithmetic context
* fix quoting in complex traceback message
 2026-01-18 12:21:49 -05:00
Zane Duffield
5988b10d16 Fix array expansion errors on unknown parameter names 
When unexpected parameters are passed to cmdarg, the shell (bash 5.1.8)
spits out some error messages about bad array subscripts, for example

> cmdarg.sh: line 333: CMDARG_FLAGS: bad array subscript
> cmdarg.sh: line 334: CMDARG_FLAGS: bad array subscript
> cmdarg.sh: line 340: CMDARG: bad array subscript

This occurs because the array is being indexed by a null value, so to
prevent it we must guard all such uses with a check.
 2026-01-18 12:21:49 -05:00
Zane Duffield
a75144bf94 Quote array expansion when appending to cmdarg_argv 
Without this change, excess arguments are split and glob-expanded when
appended to the cmdarg_argv array.
 2026-01-18 12:21:49 -05:00
Zane Duffield
35b6965e5d Quote variables to avoid word splitting a glob matching 
In all cases here, the contents of the variables are single words and do
not contain special glob characters, so it's mostly a change for
consistency and best practice.
 2026-01-18 12:21:48 -05:00
Zane Duffield
489d6d1ee8 Convert tabs to spaces 
The script used mixed indentation, meaning that it only made sense to
read when the tab width was set properly (to 8). Using consistent
indentation makes the script easier to read.
 2026-01-18 12:21:48 -05:00
1 changed files with 0 additions and 5 deletions
Expand all files Collapse all files

5
cmdarg.sh
View File

@@ -412,11 +412,6 @@ function cmdarg_dump
echo "${repr} => ${cmdarg_cfg[$key]}" echo "${repr} => ${cmdarg_cfg[$key]}"
fi fi
done done
echo "argv =>"
for idx in "${!cmdarg_argv[@]}"
do
echo " ${idx} => ${cmdarg_argv[$idx]}"
done
} }
function cmdarg_purge function cmdarg_purge