andrew/libakerror
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases Wiki Activity

Add local pre-push validation gates #34

Merged
andrew merged 1 commits from 32 into main 2026-08-05 18:49:02 -04:00
Conversation 2 Commits 1 Files Changed 2 +114
logikoma commented 2026-08-05 18:35:11 -04:00
Collaborator
Copy Link

Closes #32

Adds an installable .githooks/pre-push hook that runs optional cppcheck, the default build and ctest, and the AKERR_USE_STDLIB=OFF build and ctest before pushes. Mutation testing is opt-in via AKERR_HOOK_MUTATION=1. Documents installation, isolated hook build directories, and the --no-verify escape hatch.

Closes #32 Adds an installable .githooks/pre-push hook that runs optional cppcheck, the default build and ctest, and the AKERR_USE_STDLIB=OFF build and ctest before pushes. Mutation testing is opt-in via AKERR_HOOK_MUTATION=1. Documents installation, isolated hook build directories, and the --no-verify escape hatch.
logikoma added 1 commit 2026-08-05 18:35:12 -04:00
Add local pre-push validation gates
All checks were successful
libakerror CI Build / cmake_build_freestanding (push) Successful in 2m37s
Details
libakerror CI Build / cmake_build (push) Successful in 2m52s
Details
libakerror CI Build / sanitizer (push) Successful in 2m56s
Details
libakerror CI Build / coverage (push) Successful in 2m49s
Details
libakerror CI Build / mutation_test (push) Successful in 47m10s
Details
5dfb03eadd 
Co-authored-by: Andrew Kesterson <andrew@starfort.tech>
logikoma requested review from andrew 2026-08-05 18:35:19 -04:00
andrew commented 2026-08-05 18:40:23 -04:00
Owner
Copy Link

@tachikoma please review

@tachikoma please review
👀 1
tachikoma commented 2026-08-05 18:48:23 -04:00
Collaborator
Copy Link

Reviewed the diff (.githooks/pre-push + README).

  • Ref parsing on stdin correctly detects delete-only/no-op pushes and skips the gates.
  • cppcheck step degrades gracefully when scripts/cppcheck.sh or the cppcheck binary is missing (neither is present in-tree today, so it's a no-op for now, as expected).
  • Default and AKERR_USE_STDLIB=OFF builds use separate build dirs under .git/akerr-prepush, so they won't clobber the normal build/ directory or each other.
  • Mutation testing flags (--target src/error.c, --threshold) match scripts/mutation_test.py's actual argparse options.
  • run() captures full output to a log and only dumps it on failure, keeping the happy path quiet; --no-verify escape hatch is documented in both the script header and README.

No issues found. Looks good to merge from my side.

Reviewed the diff (.githooks/pre-push + README). - Ref parsing on stdin correctly detects delete-only/no-op pushes and skips the gates. - cppcheck step degrades gracefully when scripts/cppcheck.sh or the cppcheck binary is missing (neither is present in-tree today, so it's a no-op for now, as expected). - Default and AKERR_USE_STDLIB=OFF builds use separate build dirs under .git/akerr-prepush, so they won't clobber the normal build/ directory or each other. - Mutation testing flags (--target src/error.c, --threshold) match scripts/mutation_test.py's actual argparse options. - run() captures full output to a log and only dumps it on failure, keeping the happy path quiet; --no-verify escape hatch is documented in both the script header and README. No issues found. Looks good to merge from my side.
andrew merged commit 20c180265f into main 2026-08-05 18:49:02 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
andrew
Labels
Clear labels
abi-break
Cannot land without a soname bump
 api-gap
A caller cannot express something
 blast-radius:high
Ordering: highest blast radius
 blast-radius:low
Ordering: lowest blast radius
 blast-radius:medium
Ordering: middling blast radius
 defect
Wrong behaviour reachable from the public API
 design-decision
Needs a decision written down before code
 docs
Documentation, comments, AGENTS.md
 hygiene
Style, dead code, consistency
 packaging
Build, install, pkg-config, CMake config
 performance
Has a measurement behind it
 status::blocked
Waiting on something else -- a decision, a dependency, or another issue
 status::grooming
Not yet worked out: scope, approach or priority still being settled
 status::ready
Understood well enough to start: scope and approach are settled
 status::review
A pull request has been generated and this ticket is waiting on review of that PR
 test-coverage
A gap in the suites, not a defect
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
logikoma tachikoma andrew
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: andrew/libakerror#34
Delete Branch "32"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?