Andrew Kesterson
9924d74dcc
Closes internal-consistency items 1 through 6, 12 and 13. Every include guard is _AKGL_<FILE>_H_, every in-project header include is angled, and every exported function, type and global carries the akgl_ prefix. This is an ABI break; the soname goes to libakgl.so.0.5. TODO.md carries the full rename table. The renames were driven by renaming each declaration and letting the compiler find the uses, not by pattern substitution: renderer, physics and camera are also parameter and struct-member names, and a sed would have rewritten map->physics and every akgl_RenderBackend *renderer parameter without a word. Item 4 turned out not to be cosmetic. The library exported a global called renderer and tests/character.c defined an SDL_Renderer *renderer of its own; the executable's definition preempted the library's, akgl_sprite_load_json read a SDL_Renderer * through an akgl_RenderBackend *, and every texture load in that suite failed. The suite reported success anyway, because libakerror's unhandled-error handler ends in exit(errctx->status), exit keeps only the low byte, and AKGL_ERR_SDL is exactly 256. So character had been green while running one of its four tests, and every suite in the tree was unable to fail on the most common status in a library built on SDL. Both are fixed. tests/testutil.h gains TEST_TRAP_UNHANDLED_ERRORS(), which collapses any status a byte cannot carry onto 1, and every suite installs it. character binds a real backend with akgl_render_2d_bind. Its fourth test then runs for the first time and fails on a defect it has asserted all along, so akgl_heap_release_character now walks state_sprites with AKGL_ITERATOR_OP_RELEASE and destroys the property set before zeroing the slot -- TODO.md Defects item 21 and half of Carried over item 1. AKGL_TIME_ONESEC_MS said "one second in milliseconds" and held 1000000, so akgl_game_state_lock waited roughly sixteen minutes rather than one second. It is AKGL_TIME_ONEMS_NS now, the budget is its own named constant, and tests/game.c holds the mutex from a second thread to assert the wait -- the contended path had no coverage at all. Headers are self-contained and it is enforced: AKGL_PUBLIC_HEADERS drives both install() and a generated translation unit per header, so a header that ships is a header that is checked. Writing that found registry.h, which used SDL_PropertiesID in eight declarations and included no SDL header. 23/23 suites pass, memcheck is clean, reindent --check is clean. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
44 lines
1.6 KiB
C
44 lines
1.6 KiB
C
/**
|
|
* @file headers.c
|
|
* @brief Checks that a public header can be the first thing a caller includes.
|
|
*
|
|
* The assertion here is the compile, not anything main() does. `akgl/controller.h`
|
|
* declares its binding handlers as taking an `akgl_Actor *` and once did not
|
|
* declare that type, so every translation unit that reached for it before
|
|
* `akgl/actor.h` failed with "unknown type name 'akgl_Actor'". `src/controller.c`
|
|
* never noticed, because it includes `akgl/game.h` first.
|
|
*
|
|
* One header per file, deliberately. A second `#include` after the first proves
|
|
* nothing about the second: by then the first has already dragged its
|
|
* dependencies in. So every other public header gets its own generated
|
|
* translation unit -- `CMakeLists.txt` writes one per entry in
|
|
* `AKGL_PUBLIC_HEADERS` and links them all into this program. That list also
|
|
* drives `install()`, so a header that ships is a header that is checked.
|
|
*
|
|
* This file stays hand-written because it asserts something the generated ones
|
|
* cannot: that `akgl_Actor` is *complete* here rather than merely declared.
|
|
*/
|
|
|
|
#include <akgl/controller.h>
|
|
|
|
#include <string.h>
|
|
|
|
int main(void)
|
|
{
|
|
akgl_Control control;
|
|
|
|
// Enough to require the akgl_Actor declaration to be complete rather than
|
|
// merely present: the handler signature names it, and a control map holds
|
|
// one by value.
|
|
memset(&control, 0x00, sizeof(akgl_Control));
|
|
control.key = SDLK_LEFT;
|
|
control.handler_on = &akgl_actor_cmhf_left_on;
|
|
if ( control.handler_on == NULL ) {
|
|
return 1;
|
|
}
|
|
if ( sizeof(akgl_controlmaps) != (sizeof(akgl_ControlMap) * AKGL_MAX_CONTROL_MAPS) ) {
|
|
return 1;
|
|
}
|
|
return 0;
|
|
}
|