Andrew Kesterson
19530f6a97
Closes internal-consistency items 19 through 36, 38 and 41. Item 37, the ~180 redundant casts, is deliberately left open with its reasoning in TODO.md: the benefit only arrives once the build turns on the warnings those casts suppress, and doing it before that is churn across the two files with the most outstanding functional defects. The two that were real bugs are in the actor state table. AKGL_ACTOR_STATE_STRING_NAMES was declared [AKGL_ACTOR_MAX_STATES+1] and defined [32], so a consumer trusting the declared bound read past the object; and indices 11 and 12 were named UNDEFINED_11 and UNDEFINED_12 where actor.h has MOVING_IN and MOVING_OUT, so no character JSON could bind a sprite to either state. tests/registry.c now walks the whole table -- every entry non-NULL, every entry resolving to its own bit, no two entries sharing a name. The bitmask macros are parenthesized and AKGL_BITMASK_CLEAR has lost the semicolon inside its body. Writing tests/bitmasks.c for that turned up something worth knowing: the obvious test does not catch it. For a bit that is set, the misparse `!(mask & bit) == bit` gives the same answer as the correct one. It only diverges for an unset bit whose value is not 1, and that is the shape the suite uses now. akgl_draw_background was the last public function outside the error protocol. It takes a backend like everything else in draw.h, restores the draw colour it found, and is tested -- TODO.md had it filed under "needs the offscreen renderer harness", which was never true; what it needed was to stop reading the global. All eight registry initializers go through one helper, so the seven that leaked an SDL_PropertiesID on every call after the first no longer do. Fixed in the same place because it is the same function: akgl_registry_init never called akgl_registry_init_properties, which made akgl_set_property a silent no-op for anyone not going through akgl_game_init -- Defects, Known and still open item 3. Also: AKGL_COLLIDE_RECTANGLES (three open parens, two closes) and akgl_Frame deleted, float32_t/float64_t used consistently, the developer-specific debug logging removed from the controller inner loop, the abandoned SDL_GetBasePath comments removed, nine unused locals removed, and dst renamed to dest. akgl_game_update's default flags no longer OR the same bit twice. That changes nothing today, and the reason is Performance item 32: the loop never reads either bit, which is why every actor is updated sixteen times a frame. Still open. 25/25 pass, memcheck clean, reindent --check clean. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
24 lines
867 B
C
24 lines
867 B
C
/**
|
|
* @file types.h
|
|
* @brief Width-named floating point aliases, to match the `<stdint.h>` spelling.
|
|
*
|
|
* C names its integers by width and its floats by rank, so a struct full of
|
|
* `uint32_t` and `float` reads inconsistently. These are the float spellings the
|
|
* rest of the library uses. They are plain aliases -- no guarantee beyond what
|
|
* the platform's `float` and `double` already provide -- and are deliberately
|
|
* *not* C23's `_Float32`/`_Float64`, which carry IEEE-754 requirements this
|
|
* library does not need.
|
|
*/
|
|
|
|
#ifndef _AKGL_TYPES_H_
|
|
#define _AKGL_TYPES_H_
|
|
|
|
#include <stdint.h>
|
|
|
|
/** @brief Single-precision float. Positions, velocities, and scale factors. */
|
|
typedef float float32_t;
|
|
/** @brief Double-precision float. The physics backend keeps its drag and gravity constants at this width. */
|
|
typedef double float64_t;
|
|
|
|
#endif // _AKGL_TYPES_H_
|