andrew/libakstdlib
1
0
Fork 0
Code Issues 27 Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Add directory stream wrappers #40

Merged
andrew merged 2 commits from 10 into main 2026-08-03 15:26:00 -04:00
Conversation 0 Commits 2 Files Changed 5 +315 -1
logikoma commented 2026-08-03 13:05:26 -04:00
Collaborator
Copy Link

Closes #10.

Summary:

  • add opendir, fdopendir, readdir, closedir, and rewinddir wrappers
  • copy directory entries into caller-owned storage and report end-of-directory as AKERR_EOF
  • document DT_UNKNOWN and the stat fallback
  • cover errno propagation, null guards, EOF, copied entry lifetime, fd ownership, rewind, and root-aware EACCES behavior
  • move scandir callback and ownership design to #14 as approved

Tests:

  • cmake -S . -B build; cmake --build build -j2; ctest --test-dir build --output-on-failure (21/21)
  • ASAN_OPTIONS=detect_leaks=0 ./build-asan/test_dir
  • cmake --build build-coverage --target coverage -j2 (src/dir.c: 100% lines and functions)
Closes #10. Summary: - add opendir, fdopendir, readdir, closedir, and rewinddir wrappers - copy directory entries into caller-owned storage and report end-of-directory as AKERR_EOF - document DT_UNKNOWN and the stat fallback - cover errno propagation, null guards, EOF, copied entry lifetime, fd ownership, rewind, and root-aware EACCES behavior - move scandir callback and ownership design to #14 as approved Tests: - cmake -S . -B build; cmake --build build -j2; ctest --test-dir build --output-on-failure (21/21) - ASAN_OPTIONS=detect_leaks=0 ./build-asan/test_dir - cmake --build build-coverage --target coverage -j2 (src/dir.c: 100% lines and functions)
logikoma added 1 commit 2026-08-03 13:05:26 -04:00
Add directory stream wrappers
All checks were successful
libakstdlib CI Build / cmake_build (push) Successful in 2m56s
Details
libakstdlib CI Build / sanitizers (push) Successful in 2m53s
Details
libakstdlib CI Build / coverage (push) Successful in 2m44s
Details
libakstdlib CI Build / mutation_test (push) Successful in 13m17s
Details
af5a4b861a
logikoma force-pushed 10 from af5a4b861a to d5e5e95c61 2026-08-03 13:46:41 -04:00 Compare
andrew requested changes 2026-08-03 14:03:14 -04:00
src/dir.c
@@ -0,0 +5,4 @@
#include "aksl_internal.h"
akerr_ErrorContext AKERR_NOIGNORE *aksl_opendir(const char *pathname, DIR **dest)
andrew commented 2026-08-03 14:02:55 -04:00
Owner
Copy Link

None of these functions have man style comment blocks for context on their operations, the same way other sources in this library do.

None of these functions have `man` style comment blocks for context on their operations, the same way other sources in this library do.
andrew marked this conversation as resolved
tests/test_dir.c Outdated
@@ -0,0 +23,4 @@
DIR *dirp = (DIR *)1;
struct dirent entry;
AKSL_CHECK_STATUS(aksl_opendir("/nonexistent/aksl/dir", &dirp), ENOENT);
andrew commented 2026-08-03 14:02:26 -04:00
Owner
Copy Link

None of these checks have any comments explaining what the actual error cases are that they're testing

None of these checks have any comments explaining what the actual error cases are that they're testing
andrew marked this conversation as resolved
logikoma added 1 commit 2026-08-03 15:18:19 -04:00
Address directory wrapper review
All checks were successful
libakstdlib CI Build / cmake_build (push) Successful in 2m58s
Details
libakstdlib CI Build / sanitizers (push) Successful in 2m57s
Details
libakstdlib CI Build / coverage (push) Successful in 2m47s
Details
libakstdlib CI Build / mutation_test (push) Successful in 13m26s
Details
83ff77608f
andrew merged commit 4b22913c57 into main 2026-08-03 15:26:00 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
andrew
Labels
Clear labels
abi-break
Cannot land without a soname bump
 api-gap
A caller cannot express something
 blast-radius:high
Ordering: highest blast radius
 blast-radius:low
Ordering: lowest blast radius
 blast-radius:medium
Ordering: middling blast radius
 defect
Wrong behaviour reachable from the public API
 design-decision
Needs a decision written down before code
 docs
Documentation, comments, AGENTS.md
 hygiene
Style, dead code, consistency
 packaging
Build, install, pkg-config, CMake config
 performance
Has a measurement behind it
 status::blocked
Waiting on something else -- a decision, a dependency, or another issue
 status::grooming
Not yet worked out: scope, approach or priority still being settled
 status::ready
Understood well enough to start: scope and approach are settled
 test-coverage
A gap in the suites, not a defect
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
logikoma tachikoma andrew
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: andrew/libakstdlib#40
Delete Branch "10"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?