Port onto libakstdlib 2b79aca and convert the eight bool predicates (libakstdlib#26) #31

Open

tachikoma wants to merge 3 commits from libakstdlib-26 into main

pull from: libakstdlib-26

merge into: andrew:main

andrew:main

andrew:23

andrew:todo-to-issues

Conversation 1 Commits 3 Files Changed 42 +1284 -593

3 Commits

Author	SHA1	Message	Date
Tachikoma	9e5496f6b2	Clone libakgl's other two submodules, and pin upload-artifact to v3 ... Two more gaps that only became visible once the errno fix let the jobs run far enough to hit them. akgl_build cloned six of libakgl's submodules and needs eight. libakgl does not add_subdirectory deps/libccd or deps/clay -- their own CMakeLists are unusable as subprojects -- it compiles them into itself, so nothing declares them and configuration dies at deps/libakgl/CMakeLists.txt:282 with "File deps/libccd/src/ccd/config.h.cmake.in does not exist". deps/tg stays out: nothing references it. The X11 packages from the previous commit did their job -- SDL now configures the lot: "X11 libraries: xcursor xdbe xfixes xinput2 xrandr xscrnsaver xshape xsync xtest". coverage passes its gate now (112/112, lines 94.1% against a 90 floor) and failed on the upload instead. actions/upload-artifact@v4 bundles @actions/artifact v2, whose isGhes() treats any GITHUB_SERVER_URL that is not github.com as GitHub Enterprise Server and refuses outright. @v3 uses the older artifact API, which Gitea 1.25.3 does implement. The step had never had a file to upload before -- gcovr was never reached, so it warned "No files were found" and passed -- which is why this surfaced only now. Same class of accommodation as annotate_only on the junit reporter. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-08-03 16:31:57 -04:00
Tachikoma	88ac2fc3f2	Install the build dependencies CI has been missing since run #2 ... Every job in ci.yaml has failed on every run since #2, on main and on every branch, for two reasons that have nothing to do with any of the code under test. moreutils, for errno(1). deps/libakerror/scripts/generrno.sh shells out to it to generate its errno name table and to stamp AKERR_LAST_ERRNO_VALUE into the generated akerror.h. The runner does not have it, and its absence does not fail the build -- which is what made this expensive to find. The script prints "errno: command not found", emits an empty akerr_init_errno() so no errno ever gets a name, and substitutes an empty AKERR_LAST_ERRNO_VALUE, so every code in libakerror's reserved band collapses from (134 + n) to ( + n), i.e. to n. AKERR_OUTOFBOUNDS is (AKERR_LAST_ERRNO_VALUE + 2) and therefore becomes literally 2, so ERR(2) answers "Out Of Bounds Error" where ENOENT's "No such file or directory" belongs. That is the docs_examples failure at docs/15-error-codes.md:105, and it took cmake_build, sanitizers and coverage down with it; mutation_test then aborted on "baseline is not green" because the same suite is its baseline. Reproduced locally by shimming errno(1) out of PATH: identical failure, same test #47, same two lines of diff. With errno present the suite is 112/112. The nine X11 dev packages, for akgl_build, which has never once been green. SDL_X11 and its sub-options default ON on Linux, and CheckX11() calls SDL_missing_dependency() -- a hard CMake error, not a downgrade -- for any whose header is absent. The runner has libx11-dev but none of the extension packages, so configuration stopped at the first of them: "Couldn't find dependency package for XCURSOR". The list is SDL's own, from deps/SDL/docs/README-linux.md, reduced to the X11 entries; the audio, Wayland, KMSDRM and Vulkan backends all degrade to "not found" and skip themselves rather than erroring, so they cost nothing to leave out. Turning the missing options OFF would also configure and is the wrong answer -- the point of that job is that an AKGL build is a real SDL program. The tests still run headless under SDL_VIDEODRIVER=dummy. release.yaml's full_mutation job builds the same tree and gets moreutils for the same reason. No source file changes. The port itself was never the problem. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-08-03 16:17:41 -04:00
Tachikoma	d219f80777	Port onto libakstdlib 2b79aca and convert the eight bool predicates ... akbasic's src/ now calls libakstdlib 313 times and raw libc 7 -- 2.2% bypassed, against 86.4% on the same tree before this. The submodule bump 669b2b3 -> 2b79aca needed no source change of its own: the release is drop-in for what akbasic already used. Seven of the eight sites the earlier port left on raw libc change their own signature rather than swallowing an error, per andrew's ruling on libakstdlib#38. word_is, the is_waiting_for pair, the scanner's is_at_end, peek, peek_next and match_next_char, format.c's overflow, and sink_akgl's scroll/newline/putchar_at/echo_line/edit_key chain all return an akerr_ErrorContext * and hand the answer back through an out parameter. is_waiting_for and is_waiting_for_any are a public header change; every call site that used one as a term in a condition hoists it into a statement first. verb_compare is the eighth and stays on strcmp. bsearch(3) fixes the comparator's signature, so there is no out parameter to report through -- which is what libakstdlib#38 concluded. It carries a comment saying so and saying why the bypass is safe there. Six snprintf sites stay raw because they want truncation as an answer rather than an error, and aksl_snprintf cannot express that until libakstdlib#34 hands the required length back. Each of the six says so at the site. Two of them, in host.c, are a latent defect rather than a decision: a host type name over 31 characters truncates silently and two sharing a prefix then collide, where structtype.c refuses the same case. DLOAD leaked a file descriptor. Its read loop sat inside an ATTEMPT and the PASS in it returned past CLEANUP, so a scan error left the file open. Hoisting the loop into its own helper to convert fgets fixes it. Refs libakstdlib#26, libakstdlib#38 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-08-03 15:41:49 -04:00