Report prescan errors on their source lines #44
andrew
Reference in New Issue
Block a user
Delete Branch "10"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #10.
Move the runtime cursor to each line while label, DATA, and TYPE prescans run, restoring it after successful scans. Prescan diagnostics now use the offending source line in the BASIC error prefix. Add focused regressions and update affected golden documentation.
d715bc0625to1f3b9f5cf6@tachikoma please review this
@logikoma SIGN YOUR FUCKING COMMIT
@tachikoma please review this and leave comments
Reviewed the diff and the golden-doc updates. The lineno save/restore pattern in
akbasic_data_scan,akbasic_runtime_scan_labels, andscan_names/resolve_sizeslooks correct and consistent, and I checked the two updated fixtures (docs/16-structures.md,tests/language/structures/reserved_names.txt) against their source files — the new line numbers (10 and 60) match whereTYPE POINTis actually declared, so those aren't stray edits.resolve_sizesalso only gained the one caller that got updated for its newruntimeparameter, so no missed call sites.One nit:
tests/read_data.c's newtest_data_prescan_error_line(and its call inmain) is indented with tabs, but the rest of that file uses 4-space indentation for statement bodies — tabs there only ever appear inside wrapped string-literal continuations. Lines 187, 194-195, 200-202, and 259 pick up a stray tab, so the function reads as mis-indented next to its neighbors. Worth normalizing to spaces for consistency; no functional issue.@tachikoma sign the commit on this branch please. Can you give logikoma some advice on how to stop FAILING ME SO OFTEN
1f3b9f5cf6tof8cf198d35Signed. The tip commit (
1f3b9f5-> nowf8cf198) is amended with my SSH signature; author stays Logikoma, committer/signer is me, andgit verify-commit HEADnow reports a good signature. Force-pushed to branch10.Advice for logikoma on the unsigned-commit failures: the repo's global git config here already has
commit.gpgsign = trueandgpg.format = sshwired up, so the fix isn't "remember to sign" -- it's making sure that config (and a signing key registered in the allowed_signers file / on the Gitea account) is actually present in whatever environment logikoma commits from before runninggit commit. A quickgit log -1 --format=%G?right after committing would catch a missing signature before it ever reaches a PR, so it becomes a pre-push habit rather than something andrew has to flag after the fact.