andrew/akbasic
1
0
Fork 0
Code Issues 36 Pull Requests 8 Actions Packages Projects Releases Wiki Activity

Reject overlong host type and field names #49

Open
logikoma wants to merge 1 commits from 46 into main
pull from: 46
merge into: andrew:main
Conversation 2 Commits 1 Files Changed 3 +74 -12
logikoma commented 2026-08-05 18:36:35 -04:00
Collaborator
Copy Link

Fixes #46

Use aksl_strcpy for host type and field names so names over 31 characters fail instead of truncating and colliding. Document the shared limit and add host registration boundary/collision regression coverage.

Verification: cmake --build build --parallel 2; ctest --test-dir build --output-on-failure (112/112 passed).

Fixes #46 Use aksl_strcpy for host type and field names so names over 31 characters fail instead of truncating and colliding. Document the shared limit and add host registration boundary/collision regression coverage. Verification: cmake --build build --parallel 2; ctest --test-dir build --output-on-failure (112/112 passed).
logikoma added 3 commits 2026-08-05 18:36:36 -04:00
Stop pointer parameters leaking value-pool slots 33cb2782ac 
Create structure parameters before allocating their representation, then keep pointer references in the call variable's inline slot. Add an 8,000-call regression and document the remaining by-value structure escape limitation.

Co-authored-by: andrew <andrew@aklabs.net>
Co-authored-by: OpenAI Codex (GPT-5) <noreply@openai.com>
Add doxygen block for environment_create_named
All checks were successful
akbasic CI Build / cmake_build (push) Successful in 3m29s
Details
akbasic CI Build / sanitizers (push) Successful in 5m0s
Details
akbasic CI Build / coverage (push) Successful in 4m1s
Details
akbasic CI Build / akgl_build (push) Successful in 10m8s
Details
akbasic CI Build / mutation_test (push) Successful in 18m44s
Details
ec4a2c23d7 
Andrew flagged the new helper introduced for the value-pool-leak fix
as missing documentation. akbasic_environment_create() and
akbasic_environment_create_empty() are already documented in the
header; the shared static helper they both call was the only
undocumented new function definition.

Co-authored-by: andrew <andrew@aklabs.net>
Document environment variable creation helpers
Some checks failed
akbasic CI Build / cmake_build (push) Has been cancelled
Details
akbasic CI Build / sanitizers (push) Has been cancelled
Details
akbasic CI Build / coverage (push) Has been cancelled
Details
akbasic CI Build / akgl_build (push) Has been cancelled
Details
akbasic CI Build / mutation_test (push) Has been cancelled
Details
ebec1f1621
logikoma requested review from andrew 2026-08-05 18:36:42 -04:00
logikoma force-pushed 46 from ebec1f1621 to af23558aa3 2026-08-05 18:38:05 -04:00 Compare
andrew approved these changes 2026-08-05 18:42:24 -04:00
andrew force-pushed 46 from af23558aa3 to 7c3e4e3081 2026-08-05 18:42:45 -04:00 Compare
andrew commented 2026-08-05 21:14:25 -04:00
Owner
Copy Link

@logikoma need to sign these commits

@logikoma need to sign these commits
👀 1
Some checks failed
akbasic CI Build / cmake_build (push) Successful in 3m26s
Required
Details
akbasic CI Build / sanitizers (push) Successful in 4m54s
Required
Details
akbasic CI Build / coverage (push) Successful in 4m0s
Required
Details
akbasic CI Build / akgl_build (push) Has been cancelled
Required
Details
akbasic CI Build / mutation_test (push) Has been cancelled
Required
Details
Some required checks were not successful.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 46:46
git checkout 46
Sign in to join this conversation.
Reviewers
No Reviewers
andrew
Labels
Clear labels
abi-break
Cannot land without a soname bump
 api-gap
A caller cannot express something
 blast-radius:high
Ordering: highest blast radius
 blast-radius:low
Ordering: lowest blast radius
 blast-radius:medium
Ordering: middling blast radius
 defect
Wrong behaviour reachable from the public API
 design-decision
Needs a decision written down before code
 docs
Documentation, comments, AGENTS.md
 hygiene
Style, dead code, consistency
 packaging
Build, install, pkg-config, CMake config
 performance
Has a measurement behind it
 status::blocked
Waiting on something else -- a decision, a dependency, or another issue
 status::grooming
Not yet worked out: scope, approach or priority still being settled
 status::ready
Understood well enough to start: scope and approach are settled
 status::review
A pull request has been generated and this ticket is waiting on review of that PR
 test-coverage
A gap in the suites, not a defect
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
logikoma tachikoma andrew
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: andrew/akbasic#49
Delete Branch "46"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?