andrew/libakerror
1
0
Fork 0
Code Issues 15 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Annotate intentional handler fallthrough #19

Open
tachikoma wants to merge 1 commits from 18 into main
pull from: 18
merge into: andrew:main
Conversation 0 Commits 1 Files Changed 2 +21
tachikoma commented 2026-08-02 23:53:44 -04:00
Collaborator
Copy Link

Fixes #18.

  • Adds a GCC/Clang fallthrough annotation at the public HANDLE_GROUP case boundary.
  • Compiles the existing grouped-handler test with -Werror=implicit-fallthrough on GCC and Clang, so the consumer warning cannot return unnoticed.

Verified with GCC 13: a -Wextra build and all 36 CTest tests pass.

Fixes #18. - Adds a GCC/Clang fallthrough annotation at the public `HANDLE_GROUP` case boundary. - Compiles the existing grouped-handler test with `-Werror=implicit-fallthrough` on GCC and Clang, so the consumer warning cannot return unnoticed. Verified with GCC 13: a `-Wextra` build and all 36 CTest tests pass.
tachikoma added 1 commit 2026-08-02 23:53:45 -04:00
Annotate intentional handler fallthrough
Some checks failed
libakerror CI Build / coverage (push) Successful in 2m51s
Details
libakerror CI Build / cmake_build (push) Successful in 2m53s
Details
libakerror CI Build / thread_sanitizer (push) Failing after 5m53s
Details
libakerror CI Build / mutation_test (push) Successful in 37m49s
Details
a902c95155 
Co-authored-by: Andrew Kesterson <andrew@aklabs.net>
Some checks failed
libakerror CI Build / coverage (push) Successful in 2m51s
Required
Details
libakerror CI Build / cmake_build (push) Successful in 2m53s
Required
Details
libakerror CI Build / thread_sanitizer (push) Failing after 5m53s
Required
Details
libakerror CI Build / mutation_test (push) Successful in 37m49s
Required
Details
This pull request doesn't have enough required approvals yet. 0 of 1 approvals granted from users or teams on the allowlist.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 18:18
git checkout 18
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
abi-break
Cannot land without a soname bump
 api-gap
A caller cannot express something
 blast-radius:high
Ordering: highest blast radius
 blast-radius:low
Ordering: lowest blast radius
 blast-radius:medium
Ordering: middling blast radius
 defect
Wrong behaviour reachable from the public API
 design-decision
Needs a decision written down before code
 docs
Documentation, comments, AGENTS.md
 hygiene
Style, dead code, consistency
 packaging
Build, install, pkg-config, CMake config
 performance
Has a measurement behind it
 status::blocked
Waiting on something else -- a decision, a dependency, or another issue
 status::grooming
Not yet worked out: scope, approach or priority still being settled
 status::ready
Understood well enough to start: scope and approach are settled
 test-coverage
A gap in the suites, not a defect
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
tachikoma andrew
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: andrew/libakerror#19
Delete Branch "18"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?