andrew/libakgl
1
0
Fork 0
Code Issues 67 Pull Requests Actions Packages Projects Releases Wiki Activity

A literal 512x512 tilemap is rejected -- both bounds are >= #51

New Issue
Open
opened 2026-08-02 18:33:37 -04:00 by tachikoma · 0 comments
tachikoma commented 2026-08-02 18:33:37 -04:00
Collaborator
Copy Link

Source: TODO.md, "Found while writing the manual" -> "Defects with no prior entry", item 16 (at bbb7b8f)

src/tilemap.c:420:  if ( layerdatalen >= (AKGL_TILEMAP_MAX_WIDTH * AKGL_TILEMAP_MAX_HEIGHT) ) {
src/tilemap.c:675:  if ( (dest->width * dest->height) >= (AKGL_TILEMAP_MAX_WIDTH * AKGL_TILEMAP_MAX_HEIGHT) ) {

Both bounds are >=, so the documented AKGL_TILEMAP_MAX_WIDTH/_HEIGHT of 512
is off by one and 512x511 is the largest map that loads.

The documented maximum should load. > in both places.

Files: src/tilemap.c:420, src/tilemap.c:675

Filed by Tachikoma (Claude Code, Opus 5, 1M context)

**Source:** TODO.md, "Found while writing the manual" -> "Defects with no prior entry", item 16 (at bbb7b8f) ```c src/tilemap.c:420: if ( layerdatalen >= (AKGL_TILEMAP_MAX_WIDTH * AKGL_TILEMAP_MAX_HEIGHT) ) { src/tilemap.c:675: if ( (dest->width * dest->height) >= (AKGL_TILEMAP_MAX_WIDTH * AKGL_TILEMAP_MAX_HEIGHT) ) { ``` Both bounds are `>=`, so the documented `AKGL_TILEMAP_MAX_WIDTH`/`_HEIGHT` of 512 is off by one and **512x511 is the largest map that loads.** The documented maximum should load. `>` in both places. **Files:** `src/tilemap.c:420`, `src/tilemap.c:675` --- Filed by Tachikoma (Claude Code, Opus 5, 1M context)
tachikoma added this to the 0.9.x milestone 2026-08-02 18:33:37 -04:00
tachikoma added the defectblast-radius:low labels 2026-08-02 18:33:37 -04:00
tachikoma added the status::grooming label 2026-08-02 18:49:23 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abi-break
Cannot land without a soname bump
 api-gap
A caller cannot express something
 blast-radius:high
Ordering: highest blast radius
 blast-radius:low
Ordering: lowest blast radius
 blast-radius:medium
Ordering: middling blast radius
 defect
Wrong behaviour reachable from the public API
 design-decision
Needs a decision written down before code
 docs
Header comments, manual, AGENTS.md
 hygiene
Style, dead code, consistency
 packaging
Build, install, pkg-config, CMake config
 performance
Has a number in PERFORMANCE.md behind it
 status::blocked
Waiting on something else -- a decision, a dependency, or another issue
 status::grooming
Not yet worked out: scope, approach or priority still being settled
 status::ready
Understood well enough to start: scope and approach are settled
 test-coverage
A gap in the suites, not a defect
No Label blast-radius:low defect status::grooming
Milestone
No items
No Milestone 0.9.x
Projects
Clear projects
No project
Assignees
Clear assignees
tachikoma andrew
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: andrew/libakgl#51
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?