Andrew Kesterson
437da2960b
Every wrapper outside the list and tree code was untested. Six new test
files close that, following the plan already written in TODO.md 1.2-1.6:
test_stream.c fopen/fread/fwrite/fclose -- happy paths, the round
trip, AKERR_EOF on a short read, AKERR_IO on a stream
opened in the wrong mode, ENOENT, and the NULL guards
test_format.c printf/fprintf/sprintf -- text *and* count asserted
(stdout is pointed at a temp file to check aksl_printf),
all eight NULL guards, EBADF on a read-only stream, and
512 variadic calls in a loop as sanitizer cover for the
missing va_end
test_convert.c ato{i,l,ll,f} happy paths, negatives, leading
whitespace, NULL guards
test_path.c realpath on a file and on a symlink, both compared
against realpath(3) since TMPDIR may itself be a link;
ENOENT, ENOTDIR, NULL path
test_strhash.c djb2 known-answer vectors, len == 0, embedded NUL,
stability, NULL guards
test_convert_strict.c
known-failing (2.1.5): the AKERR_VALUE / ERANGE
contract the ato* family cannot express today
test_tree.c gains the BFS AKERR_NOT_IMPLEMENTED contract, NULL arguments,
and a callback error that is not AKERR_ITERATOR_BREAK propagating out.
Tests deliberately say nothing about behaviour TODO.md records as
defective -- unchecked ptr/mode/resolved_path, short transfers reported as
success, *count left at -1, the djb2 sign extension -- so the eventual fix
does not have to come with a test rewrite. Each failure case in
test_path.c passes a zeroed buffer, because the wrapper's own error path
formats resolved_path with %s (2.1.6).
aksl_capture.h gains aksl_temp_file() with an atexit unlink backstop.
Without it every test that fails before its own unlink leaves temp files
behind -- which is the normal case for a known-failing test, and happens
173 times over in a mutation run.
Coverage on src/stdlib.c: 52.0% -> 99.0% of lines (200/202), 23.6% ->
51.0% of branches, 8/21 -> 21/21 functions. The two uncovered lines are
both `} HANDLE(e, AKERR_ITERATOR_BREAK) {`, where the macro starts with
the `break;` of PROCESS's `case 0:` arm -- reachable only via a non-NULL
error context whose status is zero, the pathology 2.2.1 exists to remove.
Mutation score on src/stdlib.c: 46.8% -> 89.6% (155/173 killed). CI, the
pre-push hook and the docs ratchet from 40 to 80 accordingly, and the 18
survivors are grouped by cause in TODO.md and README.md. A new CI
coverage job gates at 90% lines / 45% branches.
Verified:
ctest --test-dir build # 12/12
ctest --test-dir build-asan # 12/12 under ASan + UBSan
ctest --test-dir build-coverage # 14/14, report attached
ctest --test-dir build -j8 --repeat until-fail:3
gcc -Wall -Wextra -c on all nine test files # no warnings
python3 scripts/mutation_test.py --target src/stdlib.c # 89.6%
No temp files left in /tmp after any of the above.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
129 lines
3.5 KiB
C
129 lines
3.5 KiB
C
/*
|
|
* String -> number wrappers: aksl_atoi / atol / atoll / atof.
|
|
*
|
|
* TODO.md section 1.4. This file covers the parts of the contract that are
|
|
* stable today: the happy paths (including negatives and leading whitespace)
|
|
* and the NULL guards.
|
|
*
|
|
* It deliberately says nothing about non-numeric input, trailing junk or
|
|
* overflow. Those all return *success* today (TODO.md 2.1.5) and the correct
|
|
* behaviour is asserted by tests/test_convert_strict.c, which is registered as
|
|
* a known failure. Pinning the current lax behaviour here as well would mean
|
|
* this file starts failing on the day the defect is fixed.
|
|
*/
|
|
|
|
#include "aksl_capture.h"
|
|
|
|
static int test_atoi_converts_positive(void)
|
|
{
|
|
int out = -1;
|
|
|
|
AKSL_CHECK_OK(aksl_atoi("1234", &out));
|
|
AKSL_CHECK(out == 1234);
|
|
return 0;
|
|
}
|
|
|
|
static int test_atoi_converts_negative(void)
|
|
{
|
|
int out = 0;
|
|
|
|
AKSL_CHECK_OK(aksl_atoi("-42", &out));
|
|
AKSL_CHECK(out == -42);
|
|
return 0;
|
|
}
|
|
|
|
static int test_atoi_skips_leading_whitespace(void)
|
|
{
|
|
int out = 0;
|
|
|
|
AKSL_CHECK_OK(aksl_atoi(" \t 7", &out));
|
|
AKSL_CHECK(out == 7);
|
|
return 0;
|
|
}
|
|
|
|
static int test_atoi_rejects_null_arguments(void)
|
|
{
|
|
int out = 0;
|
|
|
|
AKSL_CHECK_STATUS_MSG_CONTAINS(aksl_atoi(NULL, &out),
|
|
AKERR_NULLPOINTER, "nptr=");
|
|
AKSL_CHECK_STATUS_MSG_CONTAINS(aksl_atoi("1", NULL),
|
|
AKERR_NULLPOINTER, "dest=");
|
|
return 0;
|
|
}
|
|
|
|
static int test_atol_converts_and_rejects_null(void)
|
|
{
|
|
long out = 0;
|
|
|
|
AKSL_CHECK_OK(aksl_atol("2147483648", &out));
|
|
AKSL_CHECK(out == 2147483648L);
|
|
AKSL_CHECK_OK(aksl_atol("-2147483648", &out));
|
|
AKSL_CHECK(out == -2147483648L);
|
|
|
|
AKSL_CHECK_STATUS(aksl_atol(NULL, &out), AKERR_NULLPOINTER);
|
|
AKSL_CHECK_STATUS(aksl_atol("1", NULL), AKERR_NULLPOINTER);
|
|
return 0;
|
|
}
|
|
|
|
static int test_atoll_converts_and_rejects_null(void)
|
|
{
|
|
long long out = 0;
|
|
|
|
AKSL_CHECK_OK(aksl_atoll("9007199254740993", &out));
|
|
AKSL_CHECK(out == 9007199254740993LL);
|
|
AKSL_CHECK_OK(aksl_atoll("-9007199254740993", &out));
|
|
AKSL_CHECK(out == -9007199254740993LL);
|
|
|
|
AKSL_CHECK_STATUS(aksl_atoll(NULL, &out), AKERR_NULLPOINTER);
|
|
AKSL_CHECK_STATUS(aksl_atoll("1", NULL), AKERR_NULLPOINTER);
|
|
return 0;
|
|
}
|
|
|
|
static int test_atof_converts_and_rejects_null(void)
|
|
{
|
|
double out = 0.0;
|
|
|
|
AKSL_CHECK_OK(aksl_atof("2.5", &out));
|
|
AKSL_CHECK(out == 2.5);
|
|
AKSL_CHECK_OK(aksl_atof(" -0.125", &out));
|
|
AKSL_CHECK(out == -0.125);
|
|
|
|
AKSL_CHECK_STATUS(aksl_atof(NULL, &out), AKERR_NULLPOINTER);
|
|
AKSL_CHECK_STATUS(aksl_atof("1", NULL), AKERR_NULLPOINTER);
|
|
return 0;
|
|
}
|
|
|
|
/* The wrappers hold no state: the same input converts the same way twice. */
|
|
static int test_conversions_are_repeatable(void)
|
|
{
|
|
int first = 0;
|
|
int second = 0;
|
|
|
|
AKSL_CHECK_OK(aksl_atoi("321", &first));
|
|
AKSL_CHECK_OK(aksl_atoi("321", &second));
|
|
AKSL_CHECK(first == second);
|
|
AKSL_CHECK(first == 321);
|
|
return 0;
|
|
}
|
|
|
|
int main(void)
|
|
{
|
|
int failures = 0;
|
|
|
|
akerr_init();
|
|
|
|
AKSL_RUN(failures, test_atoi_converts_positive);
|
|
AKSL_RUN(failures, test_atoi_converts_negative);
|
|
AKSL_RUN(failures, test_atoi_skips_leading_whitespace);
|
|
AKSL_RUN(failures, test_atoi_rejects_null_arguments);
|
|
|
|
AKSL_RUN(failures, test_atol_converts_and_rejects_null);
|
|
AKSL_RUN(failures, test_atoll_converts_and_rejects_null);
|
|
AKSL_RUN(failures, test_atof_converts_and_rejects_null);
|
|
|
|
AKSL_RUN(failures, test_conversions_are_repeatable);
|
|
|
|
AKSL_REPORT(failures);
|
|
}
|