andrew/libakgl
1
0
Fork 0
Code Issues 67 Pull Requests Actions Packages Projects Releases Wiki Activity

DISABLE_GCC_WARNING_FORMAT_TRUNCATION and RESTORE_GCC_WARNINGS are dead public macros #20

New Issue
Open
opened 2026-08-02 18:33:00 -04:00 by tachikoma · 0 comments
tachikoma commented 2026-08-02 18:33:00 -04:00
Collaborator
Copy Link

Source: TODO.md, "libakstdlib wrappers not yet adopted" (at bbb7b8f)

include/akgl/error.h exports DISABLE_GCC_WARNING_FORMAT_TRUNCATION and
RESTORE_GCC_WARNINGS, and after the aksl_snprintf conversion nothing in the
tree uses either.

They are public macros, so removing them is an API change and belongs with a
version bump.

Both suppressed sites turned out to be real truncations, which is the argument
for deleting rather than keeping them: the two times this library silenced that
warning, the compiler was right.

Files: include/akgl/error.h

Filed by Tachikoma (Claude Code, Opus 5, 1M context)

**Source:** TODO.md, "libakstdlib wrappers not yet adopted" (at bbb7b8f) `include/akgl/error.h` exports `DISABLE_GCC_WARNING_FORMAT_TRUNCATION` and `RESTORE_GCC_WARNINGS`, and after the `aksl_snprintf` conversion nothing in the tree uses either. They are public macros, so removing them is an API change and belongs with a version bump. **Both suppressed sites turned out to be real truncations, which is the argument for deleting rather than keeping them: the two times this library silenced that warning, the compiler was right.** **Files:** `include/akgl/error.h` --- Filed by Tachikoma (Claude Code, Opus 5, 1M context)
tachikoma added this to the 0.10.0 milestone 2026-08-02 18:33:00 -04:00
tachikoma added the abi-breakhygieneblast-radius:low labels 2026-08-02 18:33:00 -04:00
tachikoma added the status::grooming label 2026-08-02 18:49:14 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abi-break
Cannot land without a soname bump
 api-gap
A caller cannot express something
 blast-radius:high
Ordering: highest blast radius
 blast-radius:low
Ordering: lowest blast radius
 blast-radius:medium
Ordering: middling blast radius
 defect
Wrong behaviour reachable from the public API
 design-decision
Needs a decision written down before code
 docs
Header comments, manual, AGENTS.md
 hygiene
Style, dead code, consistency
 packaging
Build, install, pkg-config, CMake config
 performance
Has a number in PERFORMANCE.md behind it
 status::blocked
Waiting on something else -- a decision, a dependency, or another issue
 status::grooming
Not yet worked out: scope, approach or priority still being settled
 status::ready
Understood well enough to start: scope and approach are settled
 test-coverage
A gap in the suites, not a defect
No Label abi-break blast-radius:low hygiene status::grooming
Milestone
No items
No Milestone 0.10.0
Projects
Clear projects
No project
Assignees
Clear assignees
tachikoma andrew
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: andrew/libakgl#20
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?