andrew/libakgl
1
0
Fork 0
Code Issues 67 Pull Requests Actions Packages Projects Releases Wiki Activity

P4: demote the hot-path SDL_Log lines to SDL_LogDebug #24

New Issue
Open
opened 2026-08-02 18:33:04 -04:00 by tachikoma · 0 comments
tachikoma commented 2026-08-02 18:33:04 -04:00
Collaborator
Copy Link

Source: TODO.md, "Performance" -> "The plan", item 4 (at bbb7b8f)

akgl_actor_initialize logs every spawn (src/actor.c:51) and
akgl_character_sprite_add every binding (src/character.c:80). 20% of a spawn
is formatting a line nobody reads, and that is with the output thrown away.

Demote them -- and src/character.c:285, src/renderer.c:34,
src/tilemap.c:660 -- from SDL_Log to SDL_LogDebug. SDL checks priority
before formatting, so the cost disappears at default priority and the messages
survive for anyone who turns debug on.

The spawn benchmark pair (tests/perf.c:410, :429) already measures exactly
this gap.

Files: src/actor.c:51, src/character.c:80,285, src/renderer.c:34, src/tilemap.c:660

Filed by Tachikoma (Claude Code, Opus 5, 1M context)

**Source:** TODO.md, "Performance" -> "The plan", item 4 (at bbb7b8f) `akgl_actor_initialize` logs every spawn (`src/actor.c:51`) and `akgl_character_sprite_add` every binding (`src/character.c:80`). **20% of a spawn is formatting a line nobody reads**, and that is with the output thrown away. Demote them -- and `src/character.c:285`, `src/renderer.c:34`, `src/tilemap.c:660` -- from `SDL_Log` to `SDL_LogDebug`. SDL checks priority before formatting, so the cost disappears at default priority and the messages survive for anyone who turns debug on. The spawn benchmark pair (`tests/perf.c:410`, `:429`) already measures exactly this gap. **Files:** `src/actor.c:51`, `src/character.c:80,285`, `src/renderer.c:34`, `src/tilemap.c:660` --- Filed by Tachikoma (Claude Code, Opus 5, 1M context)
tachikoma added this to the 0.9.x milestone 2026-08-02 18:33:04 -04:00
tachikoma added the performanceblast-radius:low labels 2026-08-02 18:33:04 -04:00
tachikoma added the status::grooming label 2026-08-02 18:49:16 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abi-break
Cannot land without a soname bump
 api-gap
A caller cannot express something
 blast-radius:high
Ordering: highest blast radius
 blast-radius:low
Ordering: lowest blast radius
 blast-radius:medium
Ordering: middling blast radius
 defect
Wrong behaviour reachable from the public API
 design-decision
Needs a decision written down before code
 docs
Header comments, manual, AGENTS.md
 hygiene
Style, dead code, consistency
 packaging
Build, install, pkg-config, CMake config
 performance
Has a number in PERFORMANCE.md behind it
 status::blocked
Waiting on something else -- a decision, a dependency, or another issue
 status::grooming
Not yet worked out: scope, approach or priority still being settled
 status::ready
Understood well enough to start: scope and approach are settled
 test-coverage
A gap in the suites, not a defect
No Label blast-radius:low performance status::grooming
Milestone
No items
No Milestone 0.9.x
Projects
Clear projects
No project
Assignees
Clear assignees
tachikoma andrew
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: andrew/libakgl#24
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?