andrew/libakgl
1
0
Fork 0
Code Issues 67 Pull Requests Actions Packages Projects Releases Wiki Activity

use_own_physics is set and never read #40

New Issue
Open
opened 2026-08-02 18:33:24 -04:00 by tachikoma · 0 comments
tachikoma commented 2026-08-02 18:33:24 -04:00
Collaborator
Copy Link

Source: TODO.md, "Found while writing the manual" -> "Defects with no prior entry", item 5 (at bbb7b8f)

akgl_tilemap_load_physics builds a complete akgl_PhysicsBackend on the map
when it declares a physics.model property, and sets map->use_own_physics
(src/tilemap.c:582) -- and nothing in the library ever consults it. The only
readers in the tree are examples/sidescroller/main.c:286 and
examples/jrpg/world.c:265.

A map's declared physics is therefore silently ignored unless the application
writes the switch itself.

README.md used to show that if, which made a caller-side workaround read like
a library feature.

Decide which it is: either akgl_game_update honours the flag, or the field
is documented as advisory and the examples stop looking like they are using an API.

Files: src/tilemap.c:582, src/game.c, include/akgl/tilemap.h:155-156

Filed by Tachikoma (Claude Code, Opus 5, 1M context)

**Source:** TODO.md, "Found while writing the manual" -> "Defects with no prior entry", item 5 (at bbb7b8f) `akgl_tilemap_load_physics` builds a complete `akgl_PhysicsBackend` on the map when it declares a `physics.model` property, and sets `map->use_own_physics` (`src/tilemap.c:582`) -- **and nothing in the library ever consults it.** The only readers in the tree are `examples/sidescroller/main.c:286` and `examples/jrpg/world.c:265`. A map's declared physics is therefore silently ignored unless the application writes the switch itself. `README.md` used to show that `if`, which made a caller-side workaround read like a library feature. **Decide which it is:** either `akgl_game_update` honours the flag, or the field is documented as advisory and the examples stop looking like they are using an API. **Files:** `src/tilemap.c:582`, `src/game.c`, `include/akgl/tilemap.h:155-156` --- Filed by Tachikoma (Claude Code, Opus 5, 1M context)
tachikoma added this to the 0.9.x milestone 2026-08-02 18:33:24 -04:00
tachikoma added the defectblast-radius:medium labels 2026-08-02 18:33:24 -04:00
tachikoma added the status::grooming label 2026-08-02 18:49:20 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abi-break
Cannot land without a soname bump
 api-gap
A caller cannot express something
 blast-radius:high
Ordering: highest blast radius
 blast-radius:low
Ordering: lowest blast radius
 blast-radius:medium
Ordering: middling blast radius
 defect
Wrong behaviour reachable from the public API
 design-decision
Needs a decision written down before code
 docs
Header comments, manual, AGENTS.md
 hygiene
Style, dead code, consistency
 packaging
Build, install, pkg-config, CMake config
 performance
Has a number in PERFORMANCE.md behind it
 status::blocked
Waiting on something else -- a decision, a dependency, or another issue
 status::grooming
Not yet worked out: scope, approach or priority still being settled
 status::ready
Understood well enough to start: scope and approach are settled
 test-coverage
A gap in the suites, not a defect
No Label blast-radius:medium defect status::grooming
Milestone
No items
No Milestone 0.9.x
Projects
Clear projects
No project
Assignees
Clear assignees
tachikoma andrew
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: andrew/libakgl#40
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?