andrew/libakgl
1
0
Fork 0
Code Issues 67 Pull Requests Actions Packages Projects Releases Wiki Activity

src/registry.c: akgl_registry_load_properties fixtures, and assert the loop leaks no strings #72

New Issue
Closed
opened 2026-08-02 18:35:17 -04:00 by tachikoma · 1 comment
tachikoma commented 2026-08-02 18:35:17 -04:00
Collaborator
Copy Link

Source: TODO.md, "Remaining work" -> "Does not need a renderer" (at bbb7b8f)

akgl_registry_load_properties needs a fixture with a properties object, plus
the missing-file, missing-key and wrong-value-type cases. src/registry.c is at
75% line coverage.

Assert the loop at src/registry.c:175-185 does not leak the string heap.
That assertion is not hypothetical: the per-property CLEANUP block is empty and
the release is the last statement inside the ATTEMPT, so a malformed property
leaks a pool slot -- filed separately as its own defect. Write the coverage and
the leak assertion together and the defect has a test the day it is fixed.

Files: tests/registry.c, src/registry.c:175-185

Filed by Tachikoma (Claude Code, Opus 5, 1M context)

**Source:** TODO.md, "Remaining work" -> "Does not need a renderer" (at bbb7b8f) `akgl_registry_load_properties` needs a fixture with a `properties` object, plus the missing-file, missing-key and wrong-value-type cases. `src/registry.c` is at 75% line coverage. **Assert the loop at `src/registry.c:175-185` does not leak the string heap.** That assertion is not hypothetical: the per-property `CLEANUP` block is empty and the release is the last statement inside the `ATTEMPT`, so a malformed property leaks a pool slot -- filed separately as its own defect. Write the coverage and the leak assertion together and the defect has a test the day it is fixed. **Files:** `tests/registry.c`, `src/registry.c:175-185` --- Filed by Tachikoma (Claude Code, Opus 5, 1M context)
tachikoma added this to the 0.9.x milestone 2026-08-02 18:35:17 -04:00
tachikoma added the test-coverageblast-radius:medium labels 2026-08-02 18:35:17 -04:00
tachikoma commented 2026-08-02 18:36:17 -04:00
Author
Collaborator
Copy Link

Duplicate of #12, filed twice by a paging bug in the script that created these -- the forge caps an issue listing at 50 per page and the de-duplication check read only the first page. Closing; #12 is the live one.

Duplicate of #12, filed twice by a paging bug in the script that created these -- the forge caps an issue listing at 50 per page and the de-duplication check read only the first page. Closing; #12 is the live one.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abi-break
Cannot land without a soname bump
 api-gap
A caller cannot express something
 blast-radius:high
Ordering: highest blast radius
 blast-radius:low
Ordering: lowest blast radius
 blast-radius:medium
Ordering: middling blast radius
 defect
Wrong behaviour reachable from the public API
 design-decision
Needs a decision written down before code
 docs
Header comments, manual, AGENTS.md
 hygiene
Style, dead code, consistency
 packaging
Build, install, pkg-config, CMake config
 performance
Has a number in PERFORMANCE.md behind it
 status::blocked
Waiting on something else -- a decision, a dependency, or another issue
 status::grooming
Not yet worked out: scope, approach or priority still being settled
 status::ready
Understood well enough to start: scope and approach are settled
 test-coverage
A gap in the suites, not a defect
No Label blast-radius:medium test-coverage
Milestone
No items
No Milestone 0.9.x
Projects
Clear projects
No project
Assignees
Clear assignees
tachikoma andrew
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: andrew/libakgl#72
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?