andrew/libakgl
1
0
Fork 0
Code Issues 67 Pull Requests Actions Packages Projects Releases Wiki Activity

akgl_actor_render hard-codes SDL_FLIP_NONE, doubling the art cost of a side-on character #44

New Issue
Open
opened 2026-08-02 18:33:28 -04:00 by tachikoma · 0 comments
tachikoma commented 2026-08-02 18:33:28 -04:00
Collaborator
Copy Link

Source: TODO.md, "Found while writing the manual" -> "Defects with no prior entry", item 9 (at bbb7b8f)

src/actor.c:283 passes SDL_FLIP_NONE to draw_texture unconditionally. There
is no mirrored blit, so a side-on character needs both facings drawn in the
sheet.

That is why docs/tutorials/assets/sidescroller/player.png carries six frames
rather than three.

The actor already knows which way it is facing -- the facing bits are in state
and the default facefunc maintains them -- so the information the blit needs is
sitting right there.

Related: actor rotation, filed separately, touches the same call and the same
decision about what renderfunc is allowed to do.

Files: src/actor.c:283

Filed by Tachikoma (Claude Code, Opus 5, 1M context)

**Source:** TODO.md, "Found while writing the manual" -> "Defects with no prior entry", item 9 (at bbb7b8f) `src/actor.c:283` passes `SDL_FLIP_NONE` to `draw_texture` unconditionally. There is no mirrored blit, so **a side-on character needs both facings drawn in the sheet.** That is why `docs/tutorials/assets/sidescroller/player.png` carries six frames rather than three. The actor already knows which way it is facing -- the facing bits are in `state` and the default `facefunc` maintains them -- so the information the blit needs is sitting right there. Related: actor rotation, filed separately, touches the same call and the same decision about what `renderfunc` is allowed to do. **Files:** `src/actor.c:283` --- Filed by Tachikoma (Claude Code, Opus 5, 1M context)
tachikoma added this to the 0.10.0 milestone 2026-08-02 18:33:28 -04:00
tachikoma added the api-gapblast-radius:medium labels 2026-08-02 18:33:28 -04:00
tachikoma added the status::grooming label 2026-08-02 18:49:21 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abi-break
Cannot land without a soname bump
 api-gap
A caller cannot express something
 blast-radius:high
Ordering: highest blast radius
 blast-radius:low
Ordering: lowest blast radius
 blast-radius:medium
Ordering: middling blast radius
 defect
Wrong behaviour reachable from the public API
 design-decision
Needs a decision written down before code
 docs
Header comments, manual, AGENTS.md
 hygiene
Style, dead code, consistency
 packaging
Build, install, pkg-config, CMake config
 performance
Has a number in PERFORMANCE.md behind it
 status::blocked
Waiting on something else -- a decision, a dependency, or another issue
 status::grooming
Not yet worked out: scope, approach or priority still being settled
 status::ready
Understood well enough to start: scope and approach are settled
 test-coverage
A gap in the suites, not a defect
No Label api-gap blast-radius:medium status::grooming
Milestone
No items
No Milestone 0.10.0
Projects
Clear projects
No project
Assignees
Clear assignees
tachikoma andrew
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: andrew/libakgl#44
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?